Skip to content

Drop iOS 14 Support: Update UTType usages (#1)#20889

Merged
kean merged 2 commits intotrunkfrom
task/ios-15-update-k-uttype-usages
Jun 16, 2023
Merged

Drop iOS 14 Support: Update UTType usages (#1)#20889
kean merged 2 commits intotrunkfrom
task/ios-15-update-k-uttype-usages

Conversation

@kean
Copy link
Contributor

@kean kean commented Jun 15, 2023

Related Issue #20860

I've been working with the updated UTType in previous PRs, for example #20887 and #20866. While some changes requires manual work, there are many where kUTType* can be automatically replaced with the new UTType APIs.

These calls are equivalent (they all return a UTI):

print(kUTTypePNG)
print(kUTTypePNG as String)
print(String(kUTTypePNG))
print(UTType.png.identifier)

Prints:

public.png
public.png
public.png
public.png

To test:

This change can potentially affect any media-related feature in the app. I tested it extensively while working on #20866, which was the first test PR that replaced deprecated kUTType* usage. I don't think it requires any additional testing at this point – just a thorough code review.

Regression Notes

  1. Potential unintended areas of impact: nearly all media-related features
  2. What I did to test those areas of impact (or what existing automated tests I relied on): manual tests
  3. What automated tests I added (or what prevented me from doing so): n/a

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@kean kean added this to the Pending milestone Jun 15, 2023
@kean kean requested review from guarani and momo-ozawa June 15, 2023 21:13
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jun 15, 2023

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr20889-d4cce34
Version22.6
Bundle IDorg.wordpress.alpha
Commitd4cce34
App Center BuildWPiOS - One-Offs #6016
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

Copy link
Contributor

@momo-ozawa momo-ozawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✨

This change can potentially affect any media-related feature in the app. I tested it extensively while working on #20866, which was the first test PR that replaced deprecated kUTType* usage. I don't think it requires any additional testing at this point – just a thorough code review.

Did a thorough code review and can confirm that UTTypes are mapped correctly.

For PRs like this that can potentially cause big regressions, I think it would be good to mention changes in release notes with an [internal] tag

@kean kean changed the title Drop iOS 14 Support: Update UTType usages Drop iOS 14 Support: Update UTType usages (#1) Jun 16, 2023
@kean
Copy link
Contributor Author

kean commented Jun 16, 2023

For PRs like this that can potentially cause big regressions, I think it would be good to mention changes in release notes with an [internal] tag

Good point, done.

@kean kean enabled auto-merge June 16, 2023 14:10
@wpmobilebot
Copy link
Contributor

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr20889-d4cce34
Version22.6
Bundle IDcom.jetpack.alpha
Commitd4cce34
App Center Buildjetpack-installable-builds #5042
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@kean kean merged commit cb5c138 into trunk Jun 16, 2023
@kean kean deleted the task/ios-15-update-k-uttype-usages branch June 16, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants