Drop iOS 14 Support: Update UTType usages (#1)#20889
Merged
Conversation
Contributor
|
| App Name | WordPress Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr20889-d4cce34 | |
| Version | 22.6 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | d4cce34 | |
| App Center Build | WPiOS - One-Offs #6016 |
momo-ozawa
approved these changes
Jun 16, 2023
Contributor
momo-ozawa
left a comment
There was a problem hiding this comment.
LGTM ✨
This change can potentially affect any media-related feature in the app. I tested it extensively while working on #20866, which was the first test PR that replaced deprecated kUTType* usage. I don't think it requires any additional testing at this point – just a thorough code review.
Did a thorough code review and can confirm that UTTypes are mapped correctly.
For PRs like this that can potentially cause big regressions, I think it would be good to mention changes in release notes with an [internal] tag
Contributor
Author
Good point, done. |
Contributor
|
| App Name | Jetpack Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr20889-d4cce34 | |
| Version | 22.6 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | d4cce34 | |
| App Center Build | jetpack-installable-builds #5042 |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Related Issue #20860
I've been working with the updated
UTTypein previous PRs, for example #20887 and #20866. While some changes requires manual work, there are many wherekUTType*can be automatically replaced with the newUTTypeAPIs.These calls are equivalent (they all return a UTI):
Prints:
To test:
This change can potentially affect any media-related feature in the app. I tested it extensively while working on #20866, which was the first test PR that replaced deprecated
kUTType*usage. I don't think it requires any additional testing at this point – just a thorough code review.Regression Notes
PR submission checklist:
RELEASE-NOTES.txtif necessary.