Comments: Remove VisualEffectView usage#20981
Merged
Conversation
1ef916c to
b8239d4
Compare
Contributor
|
| App Name | Jetpack Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr20981-48eea91 | |
| Version | 22.7 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 48eea91 | |
| App Center Build | jetpack-installable-builds #5209 |
Contributor
|
| App Name | WordPress Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr20981-b8239d4 | |
| Version | 22.7 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | b8239d4 | |
| App Center Build | WPiOS - One-Offs #6175 |
wargcm
approved these changes
Jun 30, 2023
Contributor
wargcm
left a comment
There was a problem hiding this comment.
I left a minor comment but it's just a small change so I'll still approve.
WordPress/Classes/ViewRelated/Comments/CommentTableHeaderView.swift
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Fixes n/a
VisualEffectViewwas a SwiftUI fallback implementation for materials on iOS 14. Now that we've bumped our minimum version to iOS 15 (via #20917), we can remove this custom implementation.To test
Comment moderation updatefeature flag.Regression Notes
Potential unintended areas of impact
Should be none. The component is private and only used in one place where the feature is not released.
What I did to test those areas of impact (or what existing automated tests I relied on)
Manually tested the changes.
What automated tests I added (or what prevented me from doing so)
N/A.
PR submission checklist:
RELEASE-NOTES.txtif necessary.UI Changes testing checklist: