Skip to content

Comments: Remove VisualEffectView usage#20981

Merged
dvdchr merged 2 commits intotrunkfrom
feature/remove-ios14-visualeffectview
Jul 1, 2023
Merged

Comments: Remove VisualEffectView usage#20981
dvdchr merged 2 commits intotrunkfrom
feature/remove-ios14-visualeffectview

Conversation

@dvdchr
Copy link
Contributor

@dvdchr dvdchr commented Jun 30, 2023

Fixes n/a

VisualEffectView was a SwiftUI fallback implementation for materials on iOS 14. Now that we've bumped our minimum version to iOS 15 (via #20917), we can remove this custom implementation.

To test

  • Launch the Jetpack app.
  • Turn on the Comment moderation update feature flag.
  • Go to Reader > any comment thread.
  • Verify that the comment header background is displayed in material.

Regression Notes

  1. Potential unintended areas of impact
    Should be none. The component is private and only used in one place where the feature is not released.

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Manually tested the changes.

  3. What automated tests I added (or what prevented me from doing so)
    N/A.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes testing checklist:

  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@dvdchr dvdchr added this to the 22.8 milestone Jun 30, 2023
@dvdchr dvdchr requested a review from wargcm June 30, 2023 08:35
@dvdchr dvdchr self-assigned this Jun 30, 2023
@dvdchr dvdchr force-pushed the feature/remove-ios14-visualeffectview branch from 1ef916c to b8239d4 Compare June 30, 2023 08:41
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jun 30, 2023

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr20981-48eea91
Version22.7
Bundle IDcom.jetpack.alpha
Commit48eea91
App Center Buildjetpack-installable-builds #5209
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr20981-b8239d4
Version22.7
Bundle IDorg.wordpress.alpha
Commitb8239d4
App Center BuildWPiOS - One-Offs #6175
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

Copy link
Contributor

@wargcm wargcm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a minor comment but it's just a small change so I'll still approve.

@dvdchr dvdchr enabled auto-merge July 1, 2023 06:28
@dvdchr dvdchr merged commit bfa3d0b into trunk Jul 1, 2023
@dvdchr dvdchr deleted the feature/remove-ios14-visualeffectview branch July 1, 2023 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants