Skip to content

Comments: Remove VisualEffectView usage #20981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dvdchr merged 2 commits into from
Jul 1, 2023
Merged

Comments: Remove VisualEffectView usage #20981

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b8239d4
Remove VisualEffectView
dvdchr Jun 30, 2023
48eea91
Fix background
dvdchr Jul 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 1 addition & 26 deletions WordPress/Classes/ViewRelated/Comments/CommentTableHeaderView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,18 +96,6 @@ private struct CommentHeaderView: View {
@State var showsDisclosureIndicator = true

var body: some View {
if #available(iOS 15.0, *) {
// Material ShapeStyles are only available from iOS 15.0.
content.background(.ultraThinMaterial)
} else {
ZStack {
VisualEffectView(effect: UIBlurEffect(style: .systemUltraThinMaterial))
content
}
}
}

var content: some View {
HStack {
text
Spacer()
Expand All @@ -116,6 +104,7 @@ private struct CommentHeaderView: View {
}
}
.padding(EdgeInsets(top: 10, leading: 16, bottom: 10, trailing: 16))
.background(.ultraThinMaterial)
}

var text: some View {
Expand All @@ -139,17 +128,3 @@ private struct CommentHeaderView: View {
.imageScale(.large)
}
}

// MARK: SwiftUI VisualEffect support for iOS 14

private struct VisualEffectView: UIViewRepresentable {
var effect: UIVisualEffect

func makeUIView(context: Context) -> UIVisualEffectView {
return UIVisualEffectView()
}

func updateUIView(_ uiView: UIVisualEffectView, context: Context) {
uiView.effect = effect
}
}