Skip to content

Add editor_upload_media_paused analytics event#22369

Closed
derekblank wants to merge 8 commits intotrunkfrom
feat/upload-image-paused-analytics
Closed

Add editor_upload_media_paused analytics event#22369
derekblank wants to merge 8 commits intotrunkfrom
feat/upload-image-paused-analytics

Conversation

@derekblank
Copy link
Contributor

@derekblank derekblank commented Jan 11, 2024

When a device is offline and media uploads are ongoing, track a "paused" analytics event.

Resolves:

To test:

  1. Create a post and upload an image
  2. Turn off network connectivity (via airplane mode or similar)
  3. Observe that paused event fires in addition to the failure event

Regression Notes

  1. Potential unintended areas of impact
    Analytics events

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Manual testing in Tracks

  3. What automated tests I added (or what prevented me from doing so)
    N/A (analytics)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes testing checklist:

  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@derekblank derekblank added this to the 24.1 milestone Jan 11, 2024
@derekblank derekblank requested a review from dcalhoun January 11, 2024 07:47
@derekblank
Copy link
Contributor Author

derekblank commented Jan 11, 2024

TODO:

  • Connect WPAnalyticsStatEditorUploadMediaPaused event to bypass the failed state, likely within this block:

- (void)trackUploadError:(NSError *)error
blog:(Blog *)blog
{
if (error.code == NSURLErrorCancelled) {
[WPAppAnalytics track:WPAnalyticsStatMediaServiceUploadCanceled withBlog:blog];
} else {
[WPAppAnalytics track:WPAnalyticsStatMediaServiceUploadFailed error:error withBlogID:blog.dotComID];
}
}

@derekblank derekblank added Analytics Gutenberg Editing and display of Gutenberg blocks. labels Jan 11, 2024
The paused event represents media uploads that are "paused" due to the
lack of an network connection.
The paused event represents media uploads that are "paused" due to the
lack of an network connection.
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jan 11, 2024

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr22369-873a4b5
Version24.0
Bundle IDorg.wordpress.alpha
Commit873a4b5
App Center BuildWPiOS - One-Offs #8429
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jan 11, 2024

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr22369-873a4b5
Version24.0
Bundle IDcom.jetpack.alpha
Commit873a4b5
App Center Buildjetpack-installable-builds #7452
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

The paused event represents media uploads that are "paused" due to the
lack of an network connection.
@dcalhoun
Copy link
Member

Recreating to make review easier.

@dcalhoun dcalhoun closed this Jan 12, 2024
@dcalhoun dcalhoun deleted the feat/upload-image-paused-analytics branch January 12, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Analytics Gutenberg Editing and display of Gutenberg blocks.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add EDITOR_UPLOAD_MEDIA_PAUSED analytics event

4 participants