Skip to content

Add editor_upload_media_paused analytics event#22376

Merged
dcalhoun merged 3 commits intotrunkfrom
feat/upload-image-paused-analytics-2
Jan 12, 2024
Merged

Add editor_upload_media_paused analytics event#22376
dcalhoun merged 3 commits intotrunkfrom
feat/upload-image-paused-analytics-2

Conversation

@dcalhoun
Copy link
Member

@dcalhoun dcalhoun commented Jan 12, 2024

Related

Description

When a device is offline and media uploads are ongoing, track a "paused" analytics event.

Resolves:

To test:

  1. Create a post and upload an image
  2. Turn off network connectivity (via airplane mode or similar)
  3. Observe that paused event fires in addition to the failure event

Regression Notes

  1. Potential unintended areas of impact
    Analytics events

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Manual testing in Tracks

  3. What automated tests I added (or what prevented me from doing so)
    N/A (analytics)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes testing checklist:

  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

derekblank and others added 2 commits January 11, 2024 19:58
The paused event represents media uploads that are "paused" due to the
lack of an network connection.
@dcalhoun dcalhoun added this to the 24.1 milestone Jan 12, 2024
@dcalhoun dcalhoun marked this pull request as ready for review January 12, 2024 01:04
@dcalhoun dcalhoun requested a review from derekblank January 12, 2024 01:04
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jan 12, 2024

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr22376-a974f6c
Version24.0
Bundle IDcom.jetpack.alpha
Commita974f6c
App Center Buildjetpack-installable-builds #7458
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jan 12, 2024

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr22376-a974f6c
Version24.0
Bundle IDorg.wordpress.alpha
Commita974f6c
App Center BuildWPiOS - One-Offs #8435
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noting that I chose to not add a paused event to the .thumbnailReady case as it resulted in significantly more events for a single media attachment. I felt that would likely make analysis challenging.

Copy link
Contributor

@derekblank derekblank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I was able to validate this event. 🚀

Follow the latest internal libraries operating procedures.
@dcalhoun dcalhoun enabled auto-merge January 12, 2024 14:22
@dcalhoun dcalhoun merged commit 5c2174b into trunk Jan 12, 2024
@dcalhoun dcalhoun deleted the feat/upload-image-paused-analytics-2 branch January 12, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add EDITOR_UPLOAD_MEDIA_PAUSED analytics event

4 participants