Remove Gutenberg Video block from excerpt to hide VideoPress URLs#22713
Merged
Remove Gutenberg Video block from excerpt to hide VideoPress URLs#22713
Conversation
Collaborator
1 task
Contributor
|
| App Name | WordPress Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr22713-58dbc15 | |
| Version | 24.3 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 58dbc15 | |
| App Center Build | WPiOS - One-Offs #9046 |
Contributor
|
| App Name | Jetpack Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr22713-58dbc15 | |
| Version | 24.3 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 58dbc15 | |
| App Center Build | jetpack-installable-builds #8089 |
derekblank
approved these changes
Mar 1, 2024
Contributor
derekblank
left a comment
There was a problem hiding this comment.
Approved via wordpress-mobile/WordPress-iOS-Shared#352 (review) (pending the Danger checks succeeding and WordPressShared references updating. 😄)
SiobhyB
commented
Mar 1, 2024
| ## =================================== | ||
| ## | ||
| def wordpress_shared | ||
| pod 'WordPressShared', '~> 2.3' |
Contributor
Author
There was a problem hiding this comment.
I looked at the last couple of times this reference, which was in #22376 and #20511. From those PRs, I see only the commit hash was updated in the main PR, then apps infra later created a release tag in 7fe3947 and d288944.
@mokagio, is this approach the right one? I've followed that lead with this PR, but would be keen to learn if I should have done something differently here. Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Fixes the iOS side of wordpress-mobile/gutenberg-mobile#6669
Description
See wordpress-mobile/WordPress-iOS-Shared#352 for more information and testing steps.
Regression Notes:
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR submission checklist:
RELEASE-NOTES.txtif necessary.Testing checklist: