Fix #21856: Support the 'Order' setting in pages list#24181
Merged
crazytonyli merged 1 commit intotrunkfrom Apr 14, 2025
Merged
Fix #21856: Support the 'Order' setting in pages list#24181crazytonyli merged 1 commit intotrunkfrom
crazytonyli merged 1 commit intotrunkfrom
Conversation
Collaborator
Generated by 🚫 Danger |
Contributor
|
| App Name | WordPress Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr24181-ff48310 | |
| Version | 25.8 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | ff48310 | |
| App Center Build | WPiOS - One-Offs #11621 |
Contributor
|
| App Name | Jetpack Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr24181-ff48310 | |
| Version | 25.8 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | ff48310 | |
| App Center Build | jetpack-installable-builds #10652 |
kean
reviewed
Mar 14, 2025
Contributor
kean
left a comment
There was a problem hiding this comment.
Nice fix! The code looks good, but let's hold off a little bit while Gio is working on WordPressData to avoid creating merge conflicts for him.
ff48310 to
c160ab8
Compare
Contributor
Author
|
A new Core Data model version was added in #24424. I figure it'd be okay to merge this PR since the diff is relatively small now. |
Contributor
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 27306 | |
| Version | PR #24181 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | c160ab8 | |
| Installation URL | 3s3hp1ak785d8 |
Contributor
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 27306 | |
| Version | PR #24181 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | c160ab8 | |
| Installation URL | 285lj5af75k70 |
kean
approved these changes
Apr 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Fixes #21856.
Requires wordpress-mobile/WordPressKit-iOS#832.
Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR submission checklist:
RELEASE-NOTES.txtif necessary.Testing checklist: