Skip to content

Add Blog.restApiRootURL Core Data property#24424

Merged
crazytonyli merged 1 commit intotrunkfrom
core-data-blog-rest-api-root
Apr 9, 2025
Merged

Add Blog.restApiRootURL Core Data property#24424
crazytonyli merged 1 commit intotrunkfrom
core-data-blog-rest-api-root

Conversation

@crazytonyli
Copy link
Contributor

The property will be used to store self hosted site's REST API endpoint URL, which is typically <site-url>/wp-json.

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@crazytonyli crazytonyli added this to the 25.9 milestone Apr 7, 2025
@crazytonyli crazytonyli requested review from kean and mokagio April 7, 2025 22:11
@dangermattic
Copy link
Collaborator

2 Warnings
⚠️ This PR is larger than 500 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.
⚠️ This PR is assigned to the milestone 25.9. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Apr 7, 2025

App Icon📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress
ConfigurationRelease-Alpha
Build Number27211
VersionPR #24424
Bundle IDorg.wordpress.alpha
Commitb7d8813
Installation URL5jhum3kuifdog
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Apr 7, 2025

App Icon📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack
ConfigurationRelease-Alpha
Build Number27211
VersionPR #24424
Bundle IDcom.jetpack.alpha
Commitb7d8813
Installation URL4c7u130pb3mh8
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@crazytonyli crazytonyli force-pushed the core-data-blog-rest-api-root branch from bbf6685 to 91d4a43 Compare April 8, 2025 04:16
The property will be used to store self hosted site's REST API endpoint
URL, which is typically `<site-url>/wp-json`.
@crazytonyli crazytonyli force-pushed the core-data-blog-rest-api-root branch from 91d4a43 to b7d8813 Compare April 8, 2025 04:16
Copy link
Contributor

@mokagio mokagio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also diffed 154 with the newest version added in this PR:

➜ diff WordPress/Classes/WordPress.xcdatamodeld/WordPress\ {154,155}.xcdatamodel/contents
2c2
< <model type="com.apple.IDECoreDataModeler.DataModel" documentVersion="1.0" lastSavedToolsVersion="22757" systemVersion="23E224" minimumToolsVersion="Xcode 9.0" sourceLanguage="Swift" userDefinedModelVersionIdentifier="">
---
> <model type="com.apple.IDECoreDataModeler.DataModel" documentVersion="1.0" lastSavedToolsVersion="23788" systemVersion="24D81" minimumToolsVersion="Xcode 9.0" sourceLanguage="Swift" userDefinedModelVersionIdentifier="">
159a160
>         <attribute name="restApiRootURL" optional="YES" attributeType="String" syncable="YES"/>

Looking good.

<attribute name="quickStartTypeValue" optional="YES" attributeType="Integer 16" defaultValueString="0" usesScalarValueType="YES" syncable="YES"/>
<attribute name="quotaSpaceAllowed" optional="YES" attributeType="Integer 64" usesScalarValueType="NO" syncable="YES"/>
<attribute name="quotaSpaceUsed" optional="YES" attributeType="Integer 64" usesScalarValueType="NO" syncable="YES"/>
<attribute name="restApiRootURL" optional="YES" attributeType="String" syncable="YES"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the line in the model with the new property.

@crazytonyli crazytonyli added this pull request to the merge queue Apr 9, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 9, 2025
<dict>
<key>_XCCurrentVersionName</key>
<string>WordPress 154.xcdatamodel</string>
<string>WordPress 155.xcdatamodel</string>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's remember to update this pre-production model with new namespace names.
cc @mokagio pining just in case – I think you saw it already.

@crazytonyli crazytonyli added this pull request to the merge queue Apr 9, 2025
Merged via the queue into trunk with commit 1a40645 Apr 9, 2025
31 checks passed
@crazytonyli crazytonyli deleted the core-data-blog-rest-api-root branch April 9, 2025 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants