Add Blog.restApiRootURL Core Data property#24424
Merged
crazytonyli merged 1 commit intotrunkfrom Apr 9, 2025
Merged
Conversation
Collaborator
Generated by 🚫 Danger |
Contributor
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 27211 | |
| Version | PR #24424 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | b7d8813 | |
| Installation URL | 5jhum3kuifdog |
Contributor
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 27211 | |
| Version | PR #24424 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | b7d8813 | |
| Installation URL | 4c7u130pb3mh8 |
bbf6685 to
91d4a43
Compare
The property will be used to store self hosted site's REST API endpoint URL, which is typically `<site-url>/wp-json`.
91d4a43 to
b7d8813
Compare
mokagio
approved these changes
Apr 9, 2025
Contributor
mokagio
left a comment
There was a problem hiding this comment.
Also diffed 154 with the newest version added in this PR:
➜ diff WordPress/Classes/WordPress.xcdatamodeld/WordPress\ {154,155}.xcdatamodel/contents
2c2
< <model type="com.apple.IDECoreDataModeler.DataModel" documentVersion="1.0" lastSavedToolsVersion="22757" systemVersion="23E224" minimumToolsVersion="Xcode 9.0" sourceLanguage="Swift" userDefinedModelVersionIdentifier="">
---
> <model type="com.apple.IDECoreDataModeler.DataModel" documentVersion="1.0" lastSavedToolsVersion="23788" systemVersion="24D81" minimumToolsVersion="Xcode 9.0" sourceLanguage="Swift" userDefinedModelVersionIdentifier="">
159a160
> <attribute name="restApiRootURL" optional="YES" attributeType="String" syncable="YES"/>Looking good.
| <attribute name="quickStartTypeValue" optional="YES" attributeType="Integer 16" defaultValueString="0" usesScalarValueType="YES" syncable="YES"/> | ||
| <attribute name="quotaSpaceAllowed" optional="YES" attributeType="Integer 64" usesScalarValueType="NO" syncable="YES"/> | ||
| <attribute name="quotaSpaceUsed" optional="YES" attributeType="Integer 64" usesScalarValueType="NO" syncable="YES"/> | ||
| <attribute name="restApiRootURL" optional="YES" attributeType="String" syncable="YES"/> |
Contributor
There was a problem hiding this comment.
This is the line in the model with the new property.
kean
reviewed
Apr 9, 2025
| <dict> | ||
| <key>_XCCurrentVersionName</key> | ||
| <string>WordPress 154.xcdatamodel</string> | ||
| <string>WordPress 155.xcdatamodel</string> |
Contributor
There was a problem hiding this comment.
let's remember to update this pre-production model with new namespace names.
cc @mokagio pining just in case – I think you saw it already.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


The property will be used to store self hosted site's REST API endpoint URL, which is typically
<site-url>/wp-json.Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR submission checklist:
RELEASE-NOTES.txtif necessary.Testing checklist: