#699 Use cell registration instead of inline cell creation where possible#711
Merged
pivotal-rebecca merged 6 commits intodevelopfrom Dec 9, 2013
Merged
#699 Use cell registration instead of inline cell creation where possible#711pivotal-rebecca merged 6 commits intodevelopfrom
pivotal-rebecca merged 6 commits intodevelopfrom
Conversation
- WPTableVC registers the cell with a default cell identifier for its subclasses - Clean up WPTableVC and remove all swiping functionality as it wasn’t used
- Remove other swipe view code from WPTableVC
- Remove dead code - save button is hidden unless fields are filled, so validation code not used - Add red colour used to WPStyleGuide instead of macro
Contributor
There was a problem hiding this comment.
Make sure to wrap this in NSLocalizedString
Author
There was a problem hiding this comment.
Looks like this file is gone anyways https://github.com/wordpress-mobile/WordPress-iOS/pull/692/files#diff-10
Contributor
|
|
after the one string is fixed…nto issue/699 Conflicts: WordPress/Classes/AddUsersBlogsViewController.m WordPress/Classes/BlogListViewController.m WordPress/Classes/CreateWPComAccountViewController.m WordPress/Classes/EditSiteViewController.m WordPress/Classes/ReaderPostsViewController.m WordPress/Classes/WPTableViewController.m
pivotal-rebecca
pushed a commit
that referenced
this pull request
Dec 9, 2013
#699 Use cell registration instead of inline cell creation where possible. WRT to @astralbodies comment, not fixing the string as the file is deleted in #692
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
** There is still more to do for this, but I wanted to get the PR rolling for feedback **
A fair chunk of low risk refactoring was also performed around the cell changes.
The goal is to use UITableView cell registration where appropriate, and remove the dequeue-check-create-configure pattern (to use dequeue-configure instead).