Merged
Conversation
If settings or other modal is present, dismiss it and force the Login screen
If users revoke access from the web, the app should respect that
Bigger commit than I'd like, but here's the summary: - Addded new WordPressComOAuthClient to handle OAuth2 - Skip the add blogs screen on wp.com and just add them all - Prefetch reader/notifications after successful login - Deprecate `[WordPressComApi sharedApi]` and return the default account's API instead.
Conflicts: WordPress/WordPress.xcodeproj/project.pbxproj
Previously we'd call wp.getUsersBlogs even if we have all we need from the first wp.getOptions call Also did some cleanup and removed unused methods
Since the view controller is about to be dismissed, if we pop the jetpack controller it'll go back to login for a moment while it animates out. Since the background switches from green to blue, it was a very annoying glitch.
- Use a dedicated anonymous REST API object for unauthenticated calls. Refs #22 - We get all we need to create the blog from /sites/new, don't make any extra calls - Auto login the user if registration is successful
Conflicts: WordPress/Classes/AddSiteViewController.h WordPress/Classes/AddSiteViewController.m WordPress/Classes/AddUsersBlogsViewController.h WordPress/Classes/AddUsersBlogsViewController.m WordPress/Classes/BlogListViewController.m WordPress/Classes/CreateWPComBlogViewController.m WordPress/Classes/SettingsViewController.m WordPress/Classes/WordPressAppDelegate.h WordPress/Classes/WordPressAppDelegate.m WordPress/WordPressApi/WordPressComApi.m WordPress/WordPressTest/AccountTest.m
Contributor
There was a problem hiding this comment.
Here and elsewhere, we now have the luxury of the much cleaner Blog *blog = _blogs[indexPath.row]
Contributor
|
Done reviewing this. I had mostly small comments/observations, a couple more serious things. Should be OK to merge once they're addressed. I already mentioned this, but worth mentioning again: way too much code in this pull. Makes it very hard to review with confidence. |
I don't feel much better about this than the login controller triggering it, but let's fix it properly on #22
Contributor
|
Recent changes look good, especially since refreshing the reader will be address in #22. |
tomwitkin
added a commit
that referenced
this pull request
Dec 4, 2013
#538 - Manage WordPress.com blogs
This was referenced Dec 6, 2013
Closed
pivotal-rebecca
pushed a commit
that referenced
this pull request
Dec 9, 2013
#699 Use cell registration instead of inline cell creation where possible. WRT to @astralbodies comment, not fixing the string as the file is deleted in #692
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automatically manage WordPress.com account with multiple blogs.
Fixes #538