This repository was archived by the owner on Sep 15, 2025. It is now read-only.
Conversation
Used in `ReaderPostServiceRemote`
Required updating it to return a discardable `NSProgress * _Nullable` value, as per the original API which I didn't notice.
WordPressComRESTAPIInterfacing in the Objective-C consumersWordPressComRESTAPIInterfacing in the Objective-C consumers
crazytonyli
approved these changes
Mar 24, 2024
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The bulk of this PR is going from
wordPressComRestApi GET|POSTtowordPressComRESTAPI get|post. That is, from the concrete implementation to the one referenced via the newWordPressComRESTAPIInterfacingprotocol introduced in #760 .Other than that, there are two notable changes:
baseURL: URLproperty toWordPressComRESTAPIInterfacing, 72c7132NSProgress *. This was always the behavior in the originalWordPressComRestApi, but because the return value is discardable, I didn't notice it till I run into code that required it, 83d03abTesting Details
Green CI 👌
Next up
Basically, cherry-pick the work from #738 but in a neat and reviewable order:
Bundlehelper that differentiates between SPM and CocoaPods installationsSee also, #756, #758, #760 which are related to the SPM work but independent from this one.
CHANGELOG.mdif necessary. — N.A.