This repository was archived by the owner on Sep 15, 2025. It is now read-only.
Merged
Conversation
mokagio
commented
Mar 22, 2024
Comment on lines
-10
to
-12
| 01438D352B6A2B2C0097D60A /* stats-visits-month-unit-week.json in Sources */ = {isa = PBXBuildFile; fileRef = 01438D342B6A2B2C0097D60A /* stats-visits-month-unit-week.json */; }; | ||
| 01438D362B6A31540097D60A /* stats-visits-month-unit-week.json in Resources */ = {isa = PBXBuildFile; fileRef = 01438D342B6A2B2C0097D60A /* stats-visits-month-unit-week.json */; }; | ||
| 01438D382B6A35FB0097D60A /* stats-summary.json in Sources */ = {isa = PBXBuildFile; fileRef = 01438D372B6A35FB0097D60A /* stats-summary.json */; }; |
Contributor
Author
There was a problem hiding this comment.
These were in the "Compile Sources" build phase, which was of course incorrect.
Contributor
Author
|
🤔 I disabled auto-merge because both latest builds failed on the first run with but passed on the second run. I wouldn't want to merge this PR and end up with builds semi-consistently failing. |
crazytonyli
approved these changes
Mar 24, 2024
mokagio
force-pushed
the
mokagio/xcode-15.3-and-cleanups
branch
from
8f17aa1 to
5be2c64
Compare
It conflicts with how our SwiftLint setup works. Sandboxing scripts sounds like a safe option, but in the context of this project we can afford to bypass the setting at least for the moment.
mokagio
force-pushed
the
mokagio/xcode-15.3-and-cleanups
branch
from
5be2c64 to
1451717
Compare
Contributor
Author
|
Updating to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
While working on PRs like #761, I noticed some warnings. This PR addresses them. In that process, I noticed that
Package.resolvedhad changes, which made me realize the project hadn't been updated to track the Xcode 15.3 changes. So I did that.I also went through the "Update to recommend settings" wizard. I didn't keep all the suggestions, though. The process enabled module verifier and user script sandboxing. I disabled them because they conflicted with our current setup. Given we plan to move to SPM anyway, I didn't see the point in spending additional time to comply.
Testing Details
If CI passes, we're good.
CHANGELOG.mdif necessary. — N.A.