Skip to content
This repository was archived by the owner on Sep 15, 2025. It is now read-only.

Address a few warnings#775

Merged
mokagio merged 3 commits intotrunkfrom
mokagio/cleanups-no-xcode-15.3
Apr 3, 2024
Merged

Address a few warnings#775
mokagio merged 3 commits intotrunkfrom
mokagio/cleanups-no-xcode-15.3

Conversation

@mokagio
Copy link
Contributor

@mokagio mokagio commented Apr 3, 2024

Description

This PR cherry picks the commits from #762 that are not related to Xcode 15.3. CI is consistently failing on that branch, and I think it might have to do with the new toolchain.

While I try to figure that out, I thought I'd get the warning fixes into trunk.

Since #762 has already been reviewed and approved, I'll admin-merge this on CI is green.

Testing Details

Green CI.


  • Please check here if your pull request includes additional test coverage. — N.A.
  • I have considered if this change warrants release notes and have added them to the appropriate section in the CHANGELOG.md if necessary. — N.A.

mokagio added 3 commits April 3, 2024 11:27
JSON files are resources, not sources to compile.
Xcode complained that kind of import (for Foundation?) was not
recommended.
@mokagio mokagio merged commit 7032612 into trunk Apr 3, 2024
@mokagio mokagio deleted the mokagio/cleanups-no-xcode-15.3 branch April 3, 2024 00:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant