Skip to content

Replace other_action.sh with Actions.sh#670

Merged
AliSoftware merged 3 commits intotrunkfrom
fix_configure_setup
Oct 31, 2025
Merged

Replace other_action.sh with Actions.sh#670
AliSoftware merged 3 commits intotrunkfrom
fix_configure_setup

Conversation

@wzieba
Copy link
Contributor

@wzieba wzieba commented Oct 31, 2025

What does it do?

Discussion: p1761917945519239-slack-C02KLTL3MKM

Fixes a minor issue when running configure_setup:

Stacktrace
/Users/wzieba/.rvm/gems/ruby-3.2.2/gems/fastlane-2.228.0/fastlane/lib/fastlane/other_action.rb:23:in `method_missing': [!] undefined method `trigger_action_by_name' for nil:NilClass (NoMethodError)
      self.runner.trigger_action_by_name(method_sym,
                 ^^^^^^^^^^^^^^^^^^^^^^^
    from /Users/wzieba/.rvm/gems/ruby-3.2.2/gems/fastlane-plugin-wpmreleasetoolkit-13.5.3/lib/fastlane/plugin/wpmreleasetoolkit/actions/configure/configure_apply_action.rb:52:in `prepare_repository'
    from /Users/wzieba/.rvm/gems/ruby-3.2.2/gems/fastlane-plugin-wpmreleasetoolkit-13.5.3/lib/fastlane/plugin/wpmreleasetoolkit/actions/configure/configure_apply_action.rb:16:in `run'
    from /Users/wzieba/.rvm/gems/ruby-3.2.2/gems/fastlane-plugin-wpmreleasetoolkit-13.5.3/lib/fastlane/plugin/wpmreleasetoolkit/actions/configure/configure_setup_action.rb:37:in `run'
    from /Users/wzieba/.rvm/gems/ruby-3.2.2/gems/fastlane-2.228.0/fastlane/lib/fastlane/runner.rb:263:in `block (2 levels) in execute_action'
    from /Users/wzieba/.rvm/gems/ruby-3.2.2/gems/fastlane-2.228.0/fastlane/lib/fastlane/actions/actions_helper.rb:69:in `execute_action'
    from /Users/wzieba/.rvm/gems/ruby-3.2.2/gems/fastlane-2.228.0/fastlane/lib/fastlane/runner.rb:255:in `block in execute_action'
    from /Users/wzieba/.rvm/gems/ruby-3.2.2/gems/fastlane-2.228.0/fastlane/lib/fastlane/runner.rb:229:in `chdir'
    from /Users/wzieba/.rvm/gems/ruby-3.2.2/gems/fastlane-2.228.0/fastlane/lib/fastlane/runner.rb:229:in `execute_action'
    from /Users/wzieba/.rvm/gems/ruby-3.2.2/gems/fastlane-2.228.0/fastlane/lib/fastlane/one_off.rb:42:in `run'
    from /Users/wzieba/.rvm/gems/ruby-3.2.2/gems/fastlane-2.228.0/fastlane/lib/fastlane/one_off.rb:22:in `execute'
    from /Users/wzieba/.rvm/gems/ruby-3.2.2/gems/fastlane-2.228.0/fastlane/lib/fastlane/commands_generator.rb:226:in `block (2 levels) in run'
    from /Users/wzieba/.rvm/gems/ruby-3.2.2/gems/commander-4.6.0/lib/commander/command.rb:187:in `call'
    from /Users/wzieba/.rvm/gems/ruby-3.2.2/gems/commander-4.6.0/lib/commander/command.rb:157:in `run'
    from /Users/wzieba/.rvm/gems/ruby-3.2.2/gems/commander-4.6.0/lib/commander/runner.rb:444:in `run_active_command'
    from /Users/wzieba/.rvm/gems/ruby-3.2.2/gems/fastlane-2.228.0/fastlane_core/lib/fastlane_core/ui/fastlane_runner.rb:124:in `run!'
    from /Users/wzieba/.rvm/gems/ruby-3.2.2/gems/commander-4.6.0/lib/commander/delegates.rb:18:in `run!'
    from /Users/wzieba/.rvm/gems/ruby-3.2.2/gems/fastlane-2.228.0/fastlane/lib/fastlane/commands_generator.rb:363:in `run'
    from /Users/wzieba/.rvm/gems/ruby-3.2.2/gems/fastlane-2.228.0/fastlane/lib/fastlane/commands_generator.rb:43:in `start'
    from /Users/wzieba/.rvm/gems/ruby-3.2.2/gems/fastlane-2.228.0/fastlane/lib/fastlane/cli_tools_distributor.rb:123:in `take_off'
    from /Users/wzieba/.rvm/gems/ruby-3.2.2/gems/fastlane-2.228.0/bin/fastlane:23:in `<top (required)>'
    from /Users/wzieba/.rvm/gems/ruby-3.2.2/bin/fastlane:25:in `load'
    from /Users/wzieba/.rvm/gems/ruby-3.2.2/bin/fastlane:25:in `<main>'
    from /Users/wzieba/.rvm/gems/ruby-3.2.2/bin/ruby_executable_hooks:22:in `eval'
    from /Users/wzieba/.rvm/gems/ruby-3.2.2/bin/ruby_executable_hooks:22:in `<main>'
/Users/wzieba/.rvm/gems/ruby-3.2.2/gems/fastlane-2.228.0/fastlane/lib/fastlane/other_action.rb:23:in `method_missing': undefined method `trigger_action_by_name' for nil:NilClass (NoMethodError)

Checklist before requesting a review

  • Run bundle exec rubocop to test for code style violations and recommendations.
  • Add Unit Tests (aka specs/*_spec.rb) if applicable.
  • Run bundle exec rspec to run the whole test suite and ensure all your tests pass.
  • Make sure you added an entry in the CHANGELOG.md file to describe your changes under the appropriate existing ### subsection of the existing ## Trunk section.
  • If applicable, add an entry in the MIGRATION.md file to describe how the changes will affect the migration from the previous major version and what the clients will need to change and consider.

@wzieba wzieba requested a review from AliSoftware October 31, 2025 15:54
@wzieba wzieba marked this pull request as ready for review October 31, 2025 15:54
@AliSoftware
Copy link
Contributor

Changes look good 👍
Can you add an entry in CHANGELOG.md under "Bug Fixes" for this?

Copy link
Contributor

@AliSoftware AliSoftware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@AliSoftware AliSoftware enabled auto-merge October 31, 2025 18:27
@AliSoftware AliSoftware merged commit d8150e6 into trunk Oct 31, 2025
6 checks passed
@AliSoftware AliSoftware deleted the fix_configure_setup branch October 31, 2025 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants