Skip to content

Replace other_action.sh with Actions.sh #670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AliSoftware merged 3 commits into from
Oct 31, 2025
Merged

Replace other_action.sh with Actions.sh #670

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2fe6dcd
Replace other_action.sh with Actions.sh
wzieba Oct 31, 2025
d86f2cc
Add changelog entry
wzieba Oct 31, 2025
b3e3796
Update CHANGELOG.md
AliSoftware Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ _None_

### Bug Fixes

_None_
- Fix `NoMethodError` (`undefined method 'trigger_action_by_name' for nil:NilClass`) when running `configure_setup`. [#670]

### Internal Changes

Expand Down
4 changes: 2 additions & 2 deletions lib/fastlane/plugin/wpmreleasetoolkit/actions/configure/configure_apply_action.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,14 +42,14 @@ def self.prepare_repository
original_repo_ref = Fastlane::Helper::ConfigureHelper.repo_branch_name
original_repo_ref = repo_hash if original_repo_ref.nil?

other_action.sh(command: "cd #{repository_path} && git fetch && git checkout #{file_hash}", log: false) unless repo_hash == file_hash
Actions.sh("cd #{repository_path} && git fetch && git checkout #{file_hash}", log: false) unless repo_hash == file_hash

# Run the provided block
yield

### Restore secrets repo to original branch. If it was originally in a
### detached HEAD state, we need to use the hash since there's no branch name.
other_action.sh(command: "cd #{repository_path} && git checkout #{original_repo_ref}", log: false)
Actions.sh("cd #{repository_path} && git checkout #{original_repo_ref}", log: false)
end

### Check with the user whether we should overwrite the file, if it exists
Expand Down