Skip to content

Conversation

@aomathwift
Copy link
Contributor

Resolve #437

This PR is a change to support working in a Ruby3.0.
The changes are as follows :

  • Bump up rubocop version to the newest one from 0.49.1 with automatically generating a file .rubocop_todo.yml and temporarily disabling new rules that has a large impact and cannot be enabled.
  • Updated ci.yml to work in Ruby3.0 environment.

# This configuration was generated by
# `rubocop --auto-gen-config`
# on 2017-08-24 11:09:20 +0200 using RuboCop version 0.49.1.
# on 2021-07-06 16:06:45 UTC using RuboCop version 1.12.1.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes in this file are auto-generated and do not need to be reviewed.
https://docs.rubocop.org/rubocop/configuration.html#automatically-generated-configuration

# Setup env
- uses: actions/checkout@v2
- uses: actions/setup-ruby@v1
- uses: ruby/setup-ruby@v1
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actions/setup-ruby is deprecated and recommended to use ruby/setup-ruby.

Copy link
Collaborator

@rogerluan rogerluan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤩 This is great! I think it makes sense to delay the rubocop lint issues resolution, just like you did. This keeps the changes to this PR as minimal as possible.

💪 Thank you for your contribution!

@rogerluan rogerluan changed the title Add support to ruby 3.0 add support to Ruby 3.0 Jul 6, 2021
@rogerluan rogerluan merged commit 3873eb2 into xcpretty:master Jul 6, 2021
@aomathwift aomathwift deleted the ruby-3.0 branch July 7, 2021 01:54
@maxim-lobanov
Copy link

Hello @rogerluan !
When are you planning to release the new version with these changes?

@rogerluan
Copy link
Collaborator

Thanks for the pinging me @maxim-lobanov !

I've just released a new version 😊

https://rubygems.org/gems/xcode-install/versions/2.8.0
https://github.com/xcpretty/xcode-install/releases/tag/v2.8.0

🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support to ruby 3.0

3 participants