Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,13 @@ jobs:
strategy:
fail-fast: false
matrix:
ruby: ["2.5", "2.6", "2.7"]
ruby: ["2.5", "2.6", "2.7", "3.0"]

runs-on: macos-latest
steps:
# Setup env
- uses: actions/checkout@v2
- uses: actions/setup-ruby@v1
- uses: ruby/setup-ruby@v1
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actions/setup-ruby is deprecated and recommended to use ruby/setup-ruby.

with:
ruby-version: "${{ matrix.ruby }}"

Expand All @@ -26,8 +26,8 @@ jobs:
echo $HOME

# Prepare
- name: Install bundler 2.2.14
run: gem install bundler -v "~> 2.2.14"
- name: Install bundler 2.2.20
run: gem install bundler -v "~> 2.2.20"
- name: Install ruby dependencies
run: |
bundle config --local clean 'true'
Expand Down
185 changes: 160 additions & 25 deletions .rubocop_todo.yml
Original file line number Diff line number Diff line change
@@ -1,78 +1,213 @@
# This configuration was generated by
# `rubocop --auto-gen-config`
# on 2017-08-24 11:09:20 +0200 using RuboCop version 0.49.1.
# on 2021-07-06 16:06:45 UTC using RuboCop version 1.12.1.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes in this file are auto-generated and do not need to be reviewed.
https://docs.rubocop.org/rubocop/configuration.html#automatically-generated-configuration

# The point is for the user to remove these configuration records
# one by one as the offenses are removed from the code base.
# Note that changes in the inspected code, or installation of new
# versions of RuboCop, may require this file to be generated again.

# Offense count: 1
# Configuration parameters: Include.
# Include: **/*.gemspec
Gemspec/RequiredRubyVersion:
Exclude:
- 'xcode-install.gemspec'

# Offense count: 3
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: auto_detection, squiggly, active_support, powerpack, unindent
Layout/IndentHeredoc:
Layout/ClosingHeredocIndentation:
Exclude:
- 'lib/xcode/install.rb'

# Offense count: 12
# Cop supports --auto-correct.
Layout/EmptyLineAfterGuardClause:
Exclude:
- 'lib/xcode/install.rb'
- 'lib/xcode/install/cleanup.rb'
- 'lib/xcode/install/simulators.rb'
- 'lib/xcode/install/uninstall.rb'

# Offense count: 3
# Cop supports --auto-correct.
Layout/HeredocIndentation:
Exclude:
- 'lib/xcode/install.rb'

# Offense count: 3
# Cop supports --auto-correct.
Lint/BooleanSymbol:
Exclude:
- 'lib/xcode/install/install.rb'
- 'lib/xcode/install/select.rb'
- 'lib/xcode/install/uninstall.rb'

# Offense count: 6
Lint/DuplicateMethods:
Exclude:
- 'lib/xcode/install.rb'

# Offense count: 2
# Configuration parameters: MaximumRangeSize.
Lint/MissingCopEnableDirective:
Exclude:
- 'lib/xcode/install.rb'

# Offense count: 1
# Cop supports --auto-correct.
Lint/UriRegexp:
Exclude:
- 'lib/xcode/install/install.rb'

# Offense count: 12
# Configuration parameters: IgnoredMethods, CountRepeatedAttributes.
Metrics/AbcSize:
Max: 44
Max: 45

# Offense count: 4
# Configuration parameters: CountComments, ExcludedMethods.
# Offense count: 5
# Configuration parameters: CountComments, CountAsOne, ExcludedMethods, IgnoredMethods.
# IgnoredMethods: refine
Metrics/BlockLength:
Max: 76

# Offense count: 1
# Configuration parameters: CountComments.
Metrics/ClassLength:
Max: 246

# Offense count: 3
# Offense count: 6
# Configuration parameters: IgnoredMethods.
Metrics/CyclomaticComplexity:
Max: 10

# Offense count: 11
# Configuration parameters: CountComments.
# Offense count: 17
# Configuration parameters: CountComments, CountAsOne, ExcludedMethods, IgnoredMethods.
Metrics/MethodLength:
Max: 51
Max: 50

# Offense count: 1
# Configuration parameters: CountKeywordArgs.
# Configuration parameters: CountKeywordArgs, MaxOptionalParameters.
Metrics/ParameterLists:
Max: 7

# Offense count: 3
# Offense count: 2
# Configuration parameters: IgnoredMethods.
Metrics/PerceivedComplexity:
Max: 12

# Offense count: 1
Security/MarshalLoad:
Exclude:
- 'lib/xcode/install.rb'

# Offense count: 16
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle.
# SupportedStyles: separated, grouped
Style/AccessorGrouping:
Exclude:
- 'lib/xcode/install.rb'

# Offense count: 1
Style/CombinableLoops:
Exclude:
- 'lib/xcode/install.rb'

# Offense count: 1
# Cop supports --auto-correct.
Style/Encoding:
Exclude:
- 'xcode-install.gemspec'

# Offense count: 14
# Cop supports --auto-correct.
Performance/CompareWithBlock:
Style/ExpandPathArguments:
Exclude:
- 'bin/xcversion'
- 'bin/🎉'
- 'spec/cli_spec.rb'
- 'spec/curl_spec.rb'
- 'spec/install_spec.rb'
- 'spec/installed_spec.rb'
- 'spec/installer_spec.rb'
- 'spec/json_spec.rb'
- 'spec/list_spec.rb'
- 'spec/prerelease_spec.rb'
- 'spec/spec_helper.rb'
- 'spec/uninstall_spec.rb'
- 'xcode-install.gemspec'

# Offense count: 28
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle.
# SupportedStyles: always, always_true, never
Style/FrozenStringLiteralComment:
Enabled: false

# Offense count: 2
# Cop supports --auto-correct.
Style/IfUnlessModifier:
Exclude:
- 'lib/xcode/install.rb'

# Offense count: 8
# Configuration parameters: AllowedMethods.
# AllowedMethods: respond_to_missing?
Style/OptionalBooleanParameter:
Exclude:
- 'lib/xcode/install.rb'

# Offense count: 1
# Cop supports --auto-correct.
# Configuration parameters: IncludeActiveSupportAliases.
Performance/DoubleStartEndWith:
Style/RedundantBegin:
Exclude:
- 'lib/xcode/install.rb'

# Offense count: 2
# Cop supports --auto-correct.
Style/RedundantRegexpEscape:
Exclude:
- 'lib/xcode/install.rb'

# Offense count: 1
Security/MarshalLoad:
# Cop supports --auto-correct.
# Configuration parameters: AllowMultipleReturnValues.
Style/RedundantReturn:
Exclude:
- 'lib/xcode/install.rb'

# Offense count: 15
# Offense count: 2
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles.
# Configuration parameters: EnforcedStyle.
# SupportedStyles: implicit, explicit
Style/RescueStandardError:
Exclude:
- 'lib/xcode/install.rb'

# Offense count: 1
# Cop supports --auto-correct.
# Configuration parameters: ConvertCodeThatCanStartToReturnNil, AllowedMethods.
# AllowedMethods: present?, blank?, presence, try, try!
Style/SafeNavigation:
Exclude:
- 'lib/xcode/install.rb'

# Offense count: 14
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle.
# SupportedStyles: only_raise, only_fail, semantic
Style/SignalException:
Exclude:
- 'lib/xcode/install.rb'
- 'lib/xcode/install/cli.rb'
- 'lib/xcode/install/install.rb'
- 'lib/xcode/install/select.rb'
- 'lib/xcode/install/simulators.rb'
- 'lib/xcode/install/uninstall.rb'

# Offense count: 2
# Cop supports --auto-correct.
Style/StderrPuts:
Exclude:
- 'lib/xcode/install.rb'

# Offense count: 4
# Cop supports --auto-correct.
Style/StringConcatenation:
Exclude:
- 'lib/xcode/install.rb'
- 'spec/spec_helper.rb'
2 changes: 1 addition & 1 deletion Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,5 @@ group :development do
gem 'mocha', '~> 0.11.4'
gem 'mocha-on-bacon'
gem 'prettybacon'
gem 'rubocop', '~> 0.49.1', require: false
gem 'rubocop', '~> 1.18', require: false
end