Skip to content

Conversation

@coderwander
Copy link
Contributor

fix typos

@coderwander coderwander requested a review from a team as a code owner June 10, 2025 09:37
@graphite-app
Copy link

graphite-app bot commented Jun 10, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • Queue - adds this PR to the back of the merge queue
  • Hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@macroscopeapp
Copy link

macroscopeapp bot commented Jun 10, 2025

Fix typos in TODO comment and test comment across indexer and registry packages

This pull request corrects spelling errors in two comment sections:

  • Fixes 'implementaton' to 'implementation' in a TODO comment within log_handler.go that describes how reorged events should be handled by the IReorgHandler
  • Fixes 'writter' to 'written' in a test comment within notifier_test.go that explains the purpose of a test assertion

📍Where to Start

Start with the TODO comment in log_handler.go where the typo correction explains the IReorgHandler implementation approach.


Macroscope summarized 3c0183f.

@fbac fbac enabled auto-merge (squash) June 10, 2025 09:42
@mkysel mkysel disabled auto-merge June 10, 2025 14:01
@mkysel mkysel closed this in #884 Jun 10, 2025
@mkysel mkysel reopened this Jun 10, 2025
@mkysel
Copy link
Collaborator

mkysel commented Jun 10, 2025

@coderwander can you rebase this? There is a fix in main that will allow all tests to pass.

Signed-off-by: coderwander <770732124@qq.com>
@coderwander
Copy link
Contributor Author

@coderwander can you rebase this? There is a fix in main that will allow all tests to pass.

Of course. Rebased.

@fbac fbac merged commit 0deada4 into xmtp:main Jun 11, 2025
8 checks passed
@fbac
Copy link
Collaborator

fbac commented Jun 11, 2025

Merged. Thanks @coderwander!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants