Validate provided chains with chainID #887
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
fbac
force-pushed
the
06-22-chain_validation
branch
from
e97a027 to
d4042f9
Compare
![macroscopeapp[bot]](https://avatars.githubusercontent.com/in/900172?s=60&v=4){kind=small}
fbac
force-pushed
the
06-22-chain_validation
branch
from
789becb to
ff521de
Compare
fbac
force-pushed
the
06-22-chain_validation
branch
from
ff521de to
6323382
Compare
Merged
mkysel
approved these changes
Jun 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validate provided chains with chainID by adding chain ID verification to websocket URL validation in pkg/config/validation.go
The
validateWebsocketURLfunction in pkg/config/validation.go now accepts achainIDparameter and establishes an actual connection to Ethereum nodes to verify the chain ID matches the expected value. The function performs URL parsing validation, checks for proper websocket schemes (wsorwss), connects usingethclient, and confirms the node's chain ID. Additionally, the Docker Compose script receives proper quoting for profile variables, and thegorilla/websocketdependency changes from direct to indirect status in go.mod.📍Where to Start
Start with the
validateWebsocketURLfunction in pkg/config/validation.go to understand the new chain ID validation logic.Macroscope summarized 6323382.