add -no-undefined to src/Makefile.am#85
Closed
hanetzer wants to merge 1 commit into
Closed
Conversation
Without this change building a dll with the mingw-w64 toolchain is impossible. All tests from make test-all succeed on native linux (Gentoo amd64 glibc default/linux/amd64/17.1/desktop gcc-7.2.0) Signed-off-by: Marty E. Plummer <hanetzer@protonmail.com>
hanetzer
added a commit
to hanetzer/gentoo
that referenced
this pull request
Jan 5, 2018
includes the following patches: yaml/libyaml@119b7b6 yaml/libyaml#85 Former is upstreamed, the latter is a pending pr. Without these changes a shared library/dll cannot be created on mingw-w64. Latter patch is applied also to the generated Makefile.in in order to prevent the need for eautoreconf. Package-Manager: Portage-2.3.19, Repoman-2.3.6
hanetzer
added a commit
to hanetzer/gentoo
that referenced
this pull request
Jan 5, 2018
includes the following patches: yaml/libyaml@119b7b6 yaml/libyaml#85 Former is upstreamed, the latter is a pending pr. Without these changes a shared library/dll cannot be created on mingw-w64. Latter patch is applied also to the generated Makefile.in in order to prevent the need for eautoreconf. Package-Manager: Portage-2.3.19, Repoman-2.3.6
hanetzer
added a commit
to hanetzer/gentoo
that referenced
this pull request
Jan 5, 2018
includes the following patches: yaml/libyaml@119b7b6 yaml/libyaml#85 Former is upstreamed, the latter is a pending pr. Without these changes a shared library/dll cannot be created on mingw-w64. Latter patch is applied also to the generated Makefile.in in order to prevent the need for eautoreconf. Package-Manager: Portage-2.3.19, Repoman-2.3.6
Member
|
@sigmavirus24 I created #86 to fix this, then I rebased it into this PR and pushed branch https://github.com/yaml/libyaml/tree/issue-85-test-fix. I'm not sure how to trigger a build of this on semaphore though. Do you know how? |
Contributor
Author
|
@ingydotnet No clue personally, but I also wonder if you guys are doing mingw-w64 testing on ci? From what I can tell on the appveyor log it does a cygwin based build and not a pure windows/mingw-w64 on. |
Contributor
|
I suspect closing and re-opening would trigger a new merged build. |
Member
|
@sigmavirus24 I got things working on semaphore https://semaphoreci.com/sigmavirus24/libyaml/branches/issue-85-test-fix/builds/3 but now travis is erroring #86 I'll try more tomorrow. |
Member
|
This is passing all CI tests now after rebasing in #86 PR. See:
@hanetzer after #85 is merged, rebase it into this PR please. |
Contributor
Author
|
@ingydotnet you mean, rebase #85 onto #86 once its merged? |
Contributor
|
That truly is weird that we can't reopen this. I've only ever seen that when the source repository/branch no longer exist. |
gentoo-bot
pushed a commit
to gentoo/gentoo
that referenced
this pull request
Jan 8, 2018
includes the following patches: yaml/libyaml@119b7b6 yaml/libyaml#85 Former is upstreamed, the latter is a pending PR. Without these changes a shared library/dll cannot be created on mingw-w64. Latter patch is applied also to the generated Makefile.in in order to prevent the need for eautoreconf. Package-Manager: Portage-2.3.19, Repoman-2.3.6 Closes: #6752
janhenke
pushed a commit
to janhenke/gentoo
that referenced
this pull request
Jan 8, 2018
includes the following patches: yaml/libyaml@119b7b6 yaml/libyaml#85 Former is upstreamed, the latter is a pending PR. Without these changes a shared library/dll cannot be created on mingw-w64. Latter patch is applied also to the generated Makefile.in in order to prevent the need for eautoreconf. Package-Manager: Portage-2.3.19, Repoman-2.3.6 Closes: gentoo#6752
oz123
pushed a commit
to oz123/gentoo
that referenced
this pull request
Jan 8, 2018
includes the following patches: yaml/libyaml@119b7b6 yaml/libyaml#85 Former is upstreamed, the latter is a pending PR. Without these changes a shared library/dll cannot be created on mingw-w64. Latter patch is applied also to the generated Makefile.in in order to prevent the need for eautoreconf. Package-Manager: Portage-2.3.19, Repoman-2.3.6 Closes: gentoo#6752
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this change building a dll with the mingw-w64 toolchain is
impossible. All tests from make test-all succeed on native linux
(Gentoo amd64 glibc default/linux/amd64/17.1/desktop gcc-7.2.0)
Signed-off-by: Marty E. Plummer hanetzer@protonmail.com