Fix problems in CI failures (travis and semaphore)#86
Merged
Conversation
ingydotnet
force-pushed
the
test-suite-fetch-bug
branch
2 times, most recently
from
c4b3d74 to
cd5753d
Compare
Contributor
|
I think travis needs to be told not to just pull the latest 50 commits of one branch. You need to have it pull other branches too. In the .travis.yml you could pre-fetch this branch to make it work. |
ingydotnet
force-pushed
the
test-suite-fetch-bug
branch
3 times, most recently
from
6416b0f to
8307a65
Compare
In the Makefile.am, switched out the fetch (which can have auth problems in certain envs) with a simple branch per @perlpunk++'s suggestion. With the new test branches, travis had a problem in that it only clones one branch and we need the other branch refs to be available. Fixed this by fetching the other branch refs. I also cleaned up the travis YAML file. The Ubuntu 14.04 docker image (used by semaphoreci) had an older git, without the worktree command, so I made it install the latest git from a ppa. Renamed tests/run-tests.sh to tests/run-all-tests.sh for tab completion conflict reasons.
ingydotnet
force-pushed
the
test-suite-fetch-bug
branch
from
8307a65 to
aa10f65
Compare
ingydotnet
changed the title
Member
Author
|
@sigmavirus24 yeah, I also needed to change the @sigmavirus24 can you please review this PR. I'll rebase it into #85, and then push them both to master (after you OK them both). |
Member
Author
|
#85 passes tests with this code. |
This was referenced Jan 7, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix #85 semaphore CI test failures.
@sigmavirus24, please review.
Thanks @perlpunk for fix.