Force cython when building sdist (see 196 instead)#188
Conversation
ingydotnet
left a comment
There was a problem hiding this comment.
Looks good. Would have helped me not create the bad 4.1 dist.
|
The warning probably shouldn't be in setup.py for default usage though- otherwise anyone who installs from sdist will get it. Better to have a test to make sure the dist looks like we want. |
|
@nitzmahone this error will only happen for packagers and not for normal users during install. If you want to convince yourself, check out this branch, build the sdist with |
|
I think @nitzmahone meant the warning, not the error. |
|
ah! I should learn to read more carefully :) yeah the warning probably isn't necessary given we'll have the |
|
I created #196 |
Fixes #182
thanks @asottile
Alternatively there's #33 which will only issue a warning