Force cython when building sdist#196
Merged
Merged
Conversation
asottile
reviewed
Jun 30, 2018
| if with_cython: | ||
| raise | ||
| else: | ||
| pass |
Contributor
There was a problem hiding this comment.
else:
passis a fancy noop, can just remove those two lines
Member
Author
There was a problem hiding this comment.
true, that looks fancy ;-)
will fix and force-push
asottile
approved these changes
Jun 30, 2018
Member
|
Applied. Pushed. Thanks! |
This was referenced Mar 9, 2021
This was referenced Mar 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the same as #188, but without adding the warning if cython
is not required.