Implements virtual packages as a FS layer rather than symlinks#303
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This diff reimplements the virtual package logic to use a virtual filesystem layer instead of a hard. This has many advantages:
One disadvantage is that it further abstracts the file access logic, making it more difficult for tools written in third-party languages to interop with our installs (I have Flow in mind). That said, given that these tools already have similar issues with our installs (because of the zip layer) and have a relatively low usage, it might be acceptable for now.
Note that this doesn't cause any issue with TypeScript, because TypeScript is implemented in JavaScript and thus transparently benefits from our FS layer.