Skips checking for symbolic links#520
Merged
Merged
Conversation
arcanis
force-pushed
the
mael/pnp-realpath
branch
from
5b07a13 to
5a7ebdf
Compare
larixer
pushed a commit
that referenced
this pull request
Oct 11, 2019
* Skips checking for symbolic links * Bumps versions * Updates the artifacts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
Now that we don't use symlinks anymore to disambiguate peer dependencies (#303), we don't need to take special care about what's a symlink and what isn't - we can just realpath the whole path, just like Node would do.
A followup would be to add support for a
preserveSymlinksoption.How did you fix it?
Replaced the weird symlink check by a good old
realpath.