Update main yew examples (remove static dir)#1417
Conversation
|
@philip-peterson Would you mind rebasing this? |
|
This will also break the I did some detective work and the script was added in #1165 where it was originally part of the CI but the same PR also removed it from the Travis configuration and it's been sitting there unused ever since. |
69b5c2c to
555bbce
Compare
|
@siku2 Done! |
siku2
left a comment
There was a problem hiding this comment.
This is a huge step-up from what we currently have. Thanks!
The reason there are so many comments for the Python file is because I want to keep the code style consistent.
I realise that it's kind of silly to be pedantic about it though so I only left comments with suggestions so they can easily be applied.
The file used both double and single quotes for strings. I replaced all instances with double quotes, not only because of my personal bias but also because it's more in-line with a Rust codebase.
Co-authored-by: Simon <simon@siku2.io>
|
I noticed that after stopping the server the script still prints:
as part of the EXIT trap. Since I didn't want to hold this back another day I just made the edit myself. I hope you don't mind. |
|
@philip-peterson I just noticed that the web server always adds This isn't a big issue, the examples still run perfectly fine. I only noticed because it logs a warning:
This is entirely on me for not noticing sooner, sorry about that. |
* remove static directory, move script to run_example.sh * gitignore * server infra * Support --build-only * fix npm_and_rest example * Fix various static index.html's * Fix spacing * newlines at the end * Cleanup * tabs -> spaces * line ending * remove build_examples.sh * Apply suggestions from code review Co-authored-by: Simon <simon@siku2.io> * format file and improve EXIT trap Co-authored-by: Simon <simon@siku2.io>
* remove static directory, move script to run_example.sh * gitignore * server infra * Support --build-only * fix npm_and_rest example * Fix various static index.html's * Fix spacing * newlines at the end * Cleanup * tabs -> spaces * line ending * remove build_examples.sh * Apply suggestions from code review Co-authored-by: Simon <simon@siku2.io> * format file and improve EXIT trap Co-authored-by: Simon <simon@siku2.io>
Description
Several updates to the main yew examples:
static/directory, in favor of each example directory'sstaticdirindex.htmls to load the generated JS properlyFixes #1331
Checklist:
./ci/run_stable_checks.sh