[Examples] Only add charset parameter to text mime types in content type header#1436
Merged
Merged
Conversation
jstarry
pushed a commit
that referenced
this pull request
Aug 16, 2020
teymour-aldridge
pushed a commit
to teymour-aldridge/yew
that referenced
this pull request
Sep 1, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is just a small patch for a bug which caused the web server (used for the examples) to provide an invalid content type because it always adds the
charsetparameter.It also includes some QoL improvements such as logging the url of the web server and instructing the user how to stop it.
Finally, the code was formatted to comply with pep8 guidelines.
Fixes an issue related to #1417
Checklist:
./ci/run_stable_checks.sh