Move yew/format and yew/agent to their own crates#1726
Conversation
|
Welp, looks like I based this off a wrong branch. If there's any way to fix this, please let me know, otherwise I'll have to recreate this. |
|
Visit the preview URL for this PR (updated for commit 7582236): https://yew-rs--pr1726-agent-format-crate-ci6wgitq.web.app (expires Wed, 28 Apr 2021 18:15:13 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
|
You can rebase? |
e973453 to
bd49f0b
Compare
|
Yes, a rebase fixed everything |
bd49f0b to
8724c86
Compare
8724c86 to
6cf55de
Compare
This also gets rid of unused dependencies
|
Unit tests on nightly fail because of Alexhuszagh/rust-lexical#55 so I commented out the line for those in workflow temporarily |
|
The macro unit tests are failing, not sure what's up with those. Also, in case anyone wants to take a look, this PR should be ready. |
The macro tests should be fixed on master |
# Conflicts: # packages/yew-format/src/macros.rs
|
Closing in favor of #1842 |
Description
This is 2nd part of my PR #1693. That PR moved
yew/servicesmodule toyew-services. This one movesyew/formatandyew/agenttoyew-formatandyew-agentrespectively. This is another part of the work needed to be done for #1670.I have also taken the liberty of removing some unused dependencies that were in
yewTo do list
yew/formattoyew-formatyew/agenttoyew-agentChecklist
cargo make pr-flow