Move yew/services to yew-services crate

[ranile]

Description

Move yew/services to a new yew-services crate. This is one part of the work needed to be done for #1670.

Checklist

• I have run cargo make pr-flow
  Note: I've had some of the stdweb tests fail, don't know why
• I have reviewed my own code
• I have added tests
  Not applicable, only refactoring

Note: I ensured that this code compiles with both web_sys and stdweb but I ran the tests only with web_sys

[github-actions]

Visit the preview URL for this PR (updated for commit 5e952bb):

https://yew-rs--pr1693-yew-services-grlj554u.web.app

_{(expires Sat, 30 Jan 2021 13:44:47 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

[jstarry]

Thanks @hamza1311! I'm wondering if it would be nice to keep the services feature and use it to re-export yew-services at yew::services

[ranile]

@jstarry, that won't work right now because yew-services depends on yew so there will be circular dependencies if yew depends on yew-services

Maybe we could that in a future PR when yew is broken up even more so we can avoid the circular dependency

[jstarry]

Ah right, thanks. Yeah that can come later, it probably will make sense to remove yew-services' dependency on yew altogether

[ranile]

Just bumping this.
I have resolved the conflicts so can this PR be merged now?

[ranile]

Apparently the chrome driver won't start. Any idea what might have gone wrong?

[jstarry]

Apparently the chrome driver won't start. Any idea what might have gone wrong?

Hmm, not really sure. I just retried the job

[jstarry]

I have resolved the conflicts so can this PR be merged now?

Yeah, let's get it in!

[jstarry]

There's still quite a bit of cleanup left to do. Maybe we should remove yew-stdweb first?

[ranile]

There's still quite a bit of cleanup left to do.

What you pointed out seems to be because IntelliJ's merge tool somewhat messed up. I fixed up.

Maybe we should remove yew-stdweb first?

I think if we can get this done now, it should happen. Maybe yew-agent and yew-format should happen before yew-stdweb is removed. The next steps (like yew-core as mentioned in #1670, removing yewtil, etc) should happen after we get rid of yew-stdweb. What do you think?

[jstarry]

I think if we can get this done now, it should happen.

Ok, great :)

Maybe yew-agent and yew-format should happen before yew-stdweb is removed.

Why is that?

The next steps (like yew-core as mentioned in #1670, removing yewtil, etc) should happen after we get rid of yew-stdweb. What do you think?

Yeah, that sounds good

[ranile]

Maybe yew-agent and yew-format should happen before yew-stdweb is removed.

Why is that?

Because those don't have a specific dependence on yew-stdweb. agent uses in one place and format doesn't use it at all. If it can be done without messing around too much with stdweb now then why not do it? If there's a reason not to, we can delay it.

[jstarry]

Because those don't have a specific dependence on yew-stdweb. agent uses in one place and format doesn't use it at all. If it can be done without messing around too much with stdweb now then why not do it? If there's a reason not to, we can delay it.

Ah, I see. It's ok, yew-stdweb removal is almost done anyways

[jstarry]

Looks great, @hamza1311! I just added a few small tweaks as well and will merge if CI passes. Thank you!