Skip to content

Correctly use yew::services#1741

Closed
staszewski wants to merge 3 commits into
yewstack:masterfrom
staszewski:yew-services
Closed

Correctly use yew::services#1741
staszewski wants to merge 3 commits into
yewstack:masterfrom
staszewski:yew-services

Conversation

@staszewski
Copy link
Copy Markdown

Description

When i was checking out examples i found out that they won't compile because of wrongly used yew::services. Also some link weren't working, like that:
Zrzut ekranu 2021-02-13 o 13 00 39

Checklist

  • I have run cargo make pr-flow
  • I have reviewed my own code
  • I have added tests

@github-actions
Copy link
Copy Markdown

Visit the preview URL for this PR (updated for commit 6737511):

https://yew-rs--pr1741-yew-services-mloc7gzk.web.app

(expires Sat, 20 Feb 2021 12:05:13 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@siku2
Copy link
Copy Markdown
Member

siku2 commented Feb 13, 2021

We've moved the services into a separate crate in #1693 but it has not yet been published. Do note that the "master" branch is our development branch.

@staszewski
Copy link
Copy Markdown
Author

We've moved the services into a separate crate in #1693 but it has not yet been published. Do note that the "master" branch is our development branch.

So should i close this?

@siku2
Copy link
Copy Markdown
Member

siku2 commented Feb 13, 2021

Yeah, sorry about that.
Perhaps you have an idea how we could help avoid similar situations in the future?

@staszewski staszewski closed this Feb 13, 2021
@staszewski staszewski deleted the yew-services branch February 13, 2021 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants