Skip to content

Properties 2.0#975

Merged
jstarry merged 10 commits into
yewstack:masterfrom
AlephAlpha:properties-2.0
Mar 1, 2020
Merged

Properties 2.0#975
jstarry merged 10 commits into
yewstack:masterfrom
AlephAlpha:properties-2.0

Conversation

@AlephAlpha
Copy link
Copy Markdown
Contributor

@AlephAlpha AlephAlpha commented Feb 29, 2020 •
edited by jstarry
Loading

Closes #928.

jstarry
jstarry reviewed Feb 29, 2020
View reviewed changes
Comment thread tests/macro_test.rs Outdated
jstarry
jstarry reviewed Feb 29, 2020
View reviewed changes
Comment thread tests/derive_props/pass.rs Outdated
jstarry
jstarry reviewed Feb 29, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@jstarry jstarry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Just one small fix needed

Comment thread crates/macro/src/derive_props/field.rs Outdated
Comment thread tests/derive_props/fail.stderr Outdated
@jstarry
Copy link
Copy Markdown
Member

jstarry commented Feb 29, 2020

Ah sorry, you'll have to rebase. I just merged the web-sys branch

jstarry and others added 4 commits February 29, 2020 20:16
@jstarry @daxpedda
@jplatte @jetli @AlephAlpha
Add support for building with web-sys (yewstack#961)
29b90f5 
* Enable travis

* `web-sys` general conversion (yewstack#826)

* Moved patches from different PRs.

* Add bits & pieces and some services.

* Rename `stdweb` feature to `std_web`.

* Move tests and examples to different PR.

* Revert some `cargo_web` handling removal.

* Missed something.

* Implement `console_error_panic_hook`.

* Update Cargo.toml

Co-authored-by: Justin Starry <justin.m.starry@gmail.com>

* Move document creation to util convenience method (yewstack#855)

* `web-sys` listener conversion (yewstack#813)

* `web-sys` listener initial try.

* Improve macros?

* Remove generic from `EventListenerHandle`.

* Fix build.

* A cleaner solution?

* Even cleaner.

* Fix `build.rs`.

* Minor improvements.

* Following the yew toml style.

* Fixing visibility.

* Fix `rustfmt`.

* Add `web-sys` re-exports.

* Move general changes to different PR.

* Remove compat.

* Actually remove `compat.rs`.

* Rename `stdweb` feature to `std_web`.

* Move to gloo's `EventListener` and some polish.

* Remove outdated comment.

* Change `EventHandler` to be cancelled on drop.

* `web-sys` html conversion (yewstack#817)

* Converting all `html` parts.

* Format.

* Move general changes to different PR.

* Removed compat.

* Rename `stdweb` feature to `std_web`.

* Remove redudant function copy.

* Some polish.

* Move to gloo's `EventListener`.

* Replace `unwrap`s with `expect`s.

* `web-sys` agent conversion (yewstack#818)

* Converting `agent`.

* Remove wrong `cfg` in imports.

* Move general changes to different PR.

* Some optimisations.

* Rename `stdweb` feature to `std_web`.

* Fix `ArrayBuffer` to `Uint8Array` conversions.

* Add js module worker.

* Use `cfg-if`` and `cfg-match` to make things clearer.

* Fix `std_web` build.

* Add some polish.

* Add build guards for invalid build configs (yewstack#866)

* `web_sys` cfg conversion (yewstack#862)

* Use `cfg-if` and `cfg-match` and some polish.

* Mistakes were made.

* Missed line during rebasing.

* Mistakes were undone.

* Remove global.

* Remove part of `global!`.

* `web-sys` services conversion (yewstack#827)

* Convert `console`.

* Finish services.

* Some polish.

* Fix `ArrayBuffer` to `Uint8Array` conversions.

* Fix aborting fetch leading to error and some polish.

* Replaced some `unwrap`s with `expect`s.

* Use `cfg_if` and `cfg_match` and do some polish.

* Proper scoping.

* Some fixes.

* Move fetch and reader services to different PR.

* Revert split.

* Fix CI builds (yewstack#877)

* Fix derive_props_test

* Move tests (yewstack#897) (yewstack#898)

* `web-sys` fetch service conversion (yewstack#867)

* Split implementation.

* Import global.

* Import global.

* Revert split.

* Make fetch available again.

* Revert "Revert split."

This reverts commit 6e3f101.

* Re-revert split.

* Some polish.

* Move to `wasm_bindgen_futures`.

* Switch to `thiserror`.

* wip

* Update src/services/fetch/web_sys.rs

Co-Authored-By: daxpedda <daxpedda@gmail.com>

* Some more polish.

Co-authored-by: Justin Starry <justin.m.starry@gmail.com>

* `web-sys` reader service conversion (yewstack#868)

* Split reader implementation.

* Revert split.

* Remove leftover files.

* Make reader available again.

* Revert "Revert split."

This reverts commit 8abdc9c.

* Revert "Remove leftover files."

This reverts commit 188c6eb.

* Re-revert split.

* Polish.

* Forgot some part.

* Some polish.

* Some polish.

* `web-sys` examples/tests conversion (yewstack#841)

* Fix examples/tests to work with `web_sys`.

* Update `StorageService` usage.

* Split `stdweb` and `web-sys` examples.

* Fixing the shell script.

* Trying to reset file permissions.

* Update to new reader API.

* Update to new fetch API.

* Update to new fetch API.

* Re-enable examples CI.

* Deleted duplicate example.

* Some fixes.

* Fix rand build.

* Fix spawning workers in combination with `wasm-bindgen`. (yewstack#901)

* Fix component rendering process (yewstack#913)

* wip

* Fix component rendering process

* Simplify yew-macro a bit (yewstack#902)

* yew-macro: Simplify Properties validation

* Fix most clippy warnings

* Fix clippy warnings (yewstack#912)

* Import Task trait in dashboard example

* Remove duplicate vtag tests

* Fix prevent_default() by non-passive (yewstack#958)

* Fix prevent_default() by non-passive

* Fix cargo fmt

* Remove `Option` from most services.

* Remove `Option` from resize service.

* Apply fetch changes.

* Apply reader service changes.

* Fix `node_refs` example.

* Remove web-sys travis branch

Co-authored-by: daxpedda <daxpedda@gmail.com>
Co-authored-by: Jonas Platte <jplatte@users.noreply.github.com>
Co-authored-by: Jet Li <jing.i.qin@icloud.com>
@jstarry @AlephAlpha
Fix vtag test warning (yewstack#978)
956d66e
@jstarry @AlephAlpha
Clean up exported apis and doc visibility (yewstack#977)
b0c538f 
* Clean up exported apis and doc visibility

* Remove unused ScopeHolder

* Change ComponentLink to alias of Scope

* cargo fmt
@AlephAlpha
update new examples to Properties 2.0
e3c642e
@jstarry
Copy link
Copy Markdown
Member

jstarry commented Feb 29, 2020

Still seeing conflicts on this branch. Doesn't look like the rebase worked properly

jstarry
jstarry reviewed Feb 29, 2020
View reviewed changes
Comment thread crates/macro/src/derive_props/field.rs Outdated
@totorigolo
Copy link
Copy Markdown
Contributor

totorigolo commented Feb 29, 2020

Hi there! Just a quick question: why did you choose the attributes

#[prop_or_default]
#[prop_or(...)]

instead of, for instance, serde's:

#[props(default)]
#[props(default = "path")]

@jstarry
Copy link
Copy Markdown
Member

jstarry commented Mar 1, 2020

@totorigolo there's some discussion in the issue #928. Basically, serde supports older versions of Rust and is limited to older syntax for proc macros. Since we don't have that implementation, we thought out what a more intuitive naming syntax would look like and ended up here.

@jstarry
Copy link
Copy Markdown
Member

jstarry commented Mar 1, 2020

Looks great @AlephAlpha! Thanks 👍

@jstarry jstarry merged commit afb5e9d into yewstack:master Mar 1, 2020
@AlephAlpha AlephAlpha deleted the properties-2.0 branch March 1, 2020 02:49
@Boscop Boscop mentioned this pull request Mar 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jstarry jstarry jstarry left review comments

Assignees

No one assigned

Labels

breaking change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Properties 2.0 - Required unless annotated with default value

3 participants

@AlephAlpha @jstarry @totorigolo