Merged
Conversation
Member
vjik
commented
Dec 10, 2025
vjik
commented
| Q | A |
|---|---|
| Is bugfix? | ❌ |
| New feature? | ❌ |
| Breaks BC? | ✔️ |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #123 +/- ##
============================================
- Coverage 98.59% 97.72% -0.87%
+ Complexity 97 92 -5
============================================
Files 22 22
Lines 284 264 -20
============================================
- Hits 280 258 -22
- Misses 4 6 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rustamwin
approved these changes
Dec 10, 2025
src/QueryDataReader.php
Outdated
| private FilterInterface $having = new All(), | ||
| private ?int $batchSize = null, | ||
| ?array $filterHandlers = null, | ||
| array $addFilterHandlers = [], |
Member
There was a problem hiding this comment.
Suggested change
| array $addFilterHandlers = [], | |
| array $additionalFilterHandlers = [], |
Member
Author
There was a problem hiding this comment.
Maybe call it $extraFilterHandlers ?
Member
Author
There was a problem hiding this comment.
@copilot rename addFilterHandlers to extraFilterHandlers
Tigrov
approved these changes
Dec 11, 2025
* Initial plan * Rename addFilterHandlers to extraFilterHandlers Co-authored-by: vjik <525501+vjik@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: vjik <525501+vjik@users.noreply.github.com>
samdark
approved these changes
Dec 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.