Rename addFilterHandlers to extraFilterHandlers#124
Merged
vjik merged 2 commits intoadapt-datafrom Dec 11, 2025
Merged
Conversation
Co-authored-by: vjik <525501+vjik@users.noreply.github.com>
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] Rename addFilterHandlers to extraFilterHandlers
Rename addFilterHandlers to extraFilterHandlers
Dec 11, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## adapt-data #124 +/- ##
=============================================
Coverage 97.72% 97.72%
Complexity 92 92
=============================================
Files 22 22
Lines 264 264
=============================================
Hits 258 258
Misses 6 6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renames the
$addFilterHandlersconstructor parameter to$extraFilterHandlersinQueryDataReaderfor clarity.Changes:
$addFilterHandlersto$extraFilterHandlers@psalm-paramannotationBreaking Change:
Code passing this parameter by name must update:
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.