-
-
Notifications
You must be signed in to change notification settings - Fork 456
[EXPERIMENTAL] Traitors are assigned after 3 to 5 minutes #11746
Conversation
|
This would prevent people who roll jobs that can't be traitor from rolling traitor |
|
Also, would this negate quiet mode? |
This works in the exact same way that we do traitors now, the timer is just 2 minutes instead of 1-10 seconds. |
adamsong
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks mostly good, just some small changes. Get this compiling and it can be test merged. I will definitely be interested to see how well it works.
As for the objectives, they are rolled when the datum is given, so in this case after the two minutes.
|
Does this apply to all traitor gamemodes, such as traitorlings, or just solo traitors? |
just sole traitor for now |
Don't want to approve this yet, but the requested changes were made
adamsong
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a greater variance to the start delay
|
Time to just wait 5 minutes after latejoining instead |
most people probably won't do this so we're good |
|
Seems to be working in test merge, need to do a bit more testing, and then add this to the combined modes |
|
Nifty |
|
BRO THIS ROLLED A FREE MINER AS SYNDIE ROUND 36291 |
|
Seems to also work on traitorling rounds, possibly other combo rounds |
|
So uh, there doesn't seem to be anything in place that keeps Lifegivers, Free Miners, or Charlie Station folks from being antags. That seems like a bad thing - what's a Lifegiver meant to do if they get Hijack or something? |
|
Add a check to make sure they are on the station z-level, so if a ghost role is on the station, such as free miners, they can get it, and it means they can get on the station for their objectives, otherwise they can't become traitor |
Github documenting your Pull Request
You're no longer safe from becoming a target if you latejoin.
Hopefully this helps increase the amount of people that ready up?
Untested and need to do other changes
Changelog
🆑
experimental: Traitors are only made aware of their traitor ways after approximately 2 minutes.
/:cl: