This repository was archived by the owner on May 22, 2025. It is now read-only.
Fixes "Adds digitigrade jumpsuit alts using ThatGuyPhil's icons #11744" #11884
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed digiversion and digiadjusted vars from _under.dm and any file they appear in as they are redundant - Added support to medsci, engi, security, and artist jumpsuits for digialts which I had finished but forgot to put into the PR... oops - Added digialts for wardens jacket and explorer's suit - Changed the footwrap icon so it fits digi feet. Only temperary until someone makes a resprite - Cleaned up some of my previous PRs
Yogbot-13
added
Feature
nesisknesis
approved these changes
Jul 26, 2021
Contributor
nesisknesis
left a comment
nesisknesis
left a comment
There was a problem hiding this comment.
can't go a week without jamie merging unverified art prs
- Removes the footwrap as Footwrap re-sprite yogstation13#11885 by cuackles has way better sprites than mine and to prevent a merge conflict with it. If that PR doesn't get merged, ill re-add the changes.
- Fixes chaplain's jumpsuit so it doesn't use the placeholder
Yogbot-13
added a commit
that referenced
this pull request
Aug 1, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github documenting your Pull Request
So there were a few is issues with PR #11744. For example, the digitigrade alts only worked on a few jumpsuits, footwraps wouldnt look good with them, and it was coded very poorly, this PR attempts to fix many of the issues as well as some minor stuff in my other PRs.
I removed the digiversion and digiadjusted vars from any file they appear in, as they only serve to do the same thing as mutantrace_variation. The main reason I had these was so you could have a digialt for a jumpsuit but not have it break if you dont have one for the adjusted version, but this would result in you having to define 3 vars to adding alts to jumpsuits.
I added alts for a ton of other jumpsuits, almost all of which were functional in my test server when I created the PR but didnt make it in because I forgot to upload the files. Now all job uniforms should have digialt. Also added digialts for the explorer suit and wardens jacket and changed the icons for footwraps so that they actually cover digitigrade feet.
Finally, I cleaned ups some of the stuff from #11528 and #11542. They are just unused icons and commented out things.
Wiki Documentation
I dont think anything on the wiki will be affected by this as its mostly code stuff, but I could be wrong.
Changelog
🆑
rscadd: Added many more digitigrade jumpsuit alts and two suit ones
tweak: tweaked the footwrap icons so they cover digitigrade feet
tweak: cleaned some code
/:cl: