This repository was archived by the owner on May 22, 2025. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 456
Adds Custom Mentor role, can Add Wiki and Stuff now #12014
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexkar598
suggested changes
Aug 12, 2021
Member
alexkar598
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update SQL schema
Member
|
For the record, storing the rank as a string across all rows is a stupid idea |
Contributor
|
How would you recommend storing it? |
Member
|
As an id which points to a rank |
Contributor
|
Admin ranks use a string |
Member
|
Whoever came up with that idea doesn't know how a relational database works |
Contributor
our codebase in a nutshell |
Bibby0110
reviewed
Aug 14, 2021
Contributor
|
Maybe needs a bug report but right now rementoring after dementoring makes your role show up as [] when you talk in OOC |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Custom Mentor role, can Add Wiki and Stuff now