Skip to content
This repository was archived by the owner on May 22, 2025. It is now read-only.

Conversation

@adamsong
Copy link
Contributor

@adamsong adamsong commented Sep 6, 2021

Github documenting your Pull Request

You shouldn't be able to bypass global OOC toggles or the pretty filter with disocrd

Changelog

🆑
rscadd: Applied the pretty filter and OOC toggle to discord OOC
/:cl:

@Bluedazzled
Copy link
Contributor

but... but my ඞ!

@Firewolf34
Copy link
Contributor

Firewolf34 commented Sep 6, 2021

THANK GOD. ANOTHER HAND TOUCHES THE BEACON

I worked on muting Discord-OOC with Altoids (@Altoids1 ?) back when he was Maintainer - but we never published it because there was no easy way to only mute non-Admin Discord chats using the toggle.

Something to consider for your PR. Admin Discord messages and such from Discord were requested to us to not be muted back then regardless of player preference. I don't know if that's still the case but that's why this was not done earlier. Interacting with the Discord API/bot/thing to include Discord roles into decision was complicated and required modifications to the Discord plugin.

@JamieD1
Copy link
Contributor

JamieD1 commented Sep 6, 2021

Hes right, kinda shitty that admins cant type, but eh might just be easier to do it this way without having to piss around with the plugin.

@adamsong
Copy link
Contributor Author

adamsong commented Sep 6, 2021

If admins need to type, they can hop in game

@missatessatessy
Copy link
Contributor

Couldn't you have a second ooc channel on the discord that only admins can access so they can bypass a mute toggle on the public one?

@adamsong
Copy link
Contributor Author

adamsong commented Sep 8, 2021

Possibly, but that is effort, and involving systems I don't understand, while this pr involves systems I think I understand.

@Bibby0110 Bibby0110 merged commit 1408b6d into master Sep 9, 2021
@Bibby0110 Bibby0110 deleted the pretty-discord branch September 9, 2021 15:38
@Yogbot-13 Yogbot-13 added the Feature This adds new content to the game label Sep 9, 2021
Yogbot-13 added a commit that referenced this pull request Sep 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Feature This adds new content to the game

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants