Skip to content
This repository was archived by the owner on May 22, 2025. It is now read-only.

Conversation

@nmajask
Copy link
Contributor

@nmajask nmajask commented Oct 20, 2021

Document the changes in your pull request

Ports some modular computer changes from TG. I'm not atomizing this to start because it would take the rest of my natural life to PR then wait then PR each of them, also I just want to rip the bandaid off and get them done. Minimal testing was done and minor tweaks were made to help them work with our unique modular computer changes (aka phones).

List of Ports

Full Ports

Partial Ports

Wiki Documentation

Nothing will need to be changed, as most of what is changed is not stuff you will notice in game, or relating to modular computers.

Changelog

🆑 zxaber, Rohesie, MTandi, Mothblocks, Timberpoes
rscadd: Added support for modular PC expansion bays
tweak: The AI card slot, printer, and APC-siphoning recharger are now expansion bay hardware.
tweak: The modular PC atmos scanner, now requires a new expansion bay hardware item - the sensor package.
tweak: Modular PC card readers have been split
bugfix: Buying a tablet from the Laptop/Tablet vendor, and paying extra for the nano printer, will now attach the correct printer rather than attempt to stuff a laptop printer into a tablet and silently fail but still take your cash.
tweak: The NtOS home screen has been updated with disk and ID eject buttons.
rscadd: The Supermatter Monitoring app will now send notifications if the app is closed with a supermatter selected, and the selected supermatter starts delaminating.
bugfix: Modular computer batteries are now deleted when the power cell controller is deleted.
tweak: Software Downloader program UI revamp
bugfix: Modular consoles can now be attacked
bugfix: Modular laptops and tablets will no longer experience abnormal behaviour including unclickable UI elements when placed in your bag, and will now close their interfaces appropriately.
rscadd: Lifeline and Fission360, the apps that track suit sensors and nuke disks respectively, now show the tracking status on the screen of the tablet/laptop object itself, without needing to keep the window open.
/:cl:

Ports a lot of stuff from TG, some of it might even work!
@nmajask nmajask requested a review from a team as a code owner October 20, 2021 03:20
Should fix the failed check
@SomeguyManperson SomeguyManperson added the Test Merge - Scheduled This PR is waiting to be test merged label Oct 22, 2021
Removes the old syndicate tablet preset with the nukie one and adds command and atmos phone presets. Replaces all head tablets with phones and fixes atmos techs starting with tablets.
@JamieD1
Copy link
Contributor

JamieD1 commented Oct 31, 2021

Waiting for Ident to look.

Yogbot-13 added a commit that referenced this pull request Oct 31, 2021
@rebaia rebaia mentioned this pull request Nov 3, 2021
Yogbot-13 added a commit that referenced this pull request Nov 14, 2021
@JamieD1 JamieD1 merged commit a0b6b72 into yogstation13:master Nov 14, 2021
@Yogbot-13 Yogbot-13 added Feature This adds new content to the game Fix This fixes an issue. Please link issues in fix PRs Tweak This PR contains changes to the game. labels Nov 14, 2021
Yogbot-13 added a commit that referenced this pull request Nov 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Feature This adds new content to the game Fix This fixes an issue. Please link issues in fix PRs Test Merge - Scheduled This PR is waiting to be test merged Tweak This PR contains changes to the game.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants