Skip to content
This repository was archived by the owner on May 22, 2025. It is now read-only.

Conversation

@nmajask
Copy link
Contributor

@nmajask nmajask commented Dec 10, 2021

Document the changes in your pull request

Renames Yogstation to YogsBox in, hopefully, the map vote and internally, as that is what everyone refers to it as and naming it after the server probably isn't the best idea. Will probably cause merge conflicts, but it shouldn't be hard to fix. Untested, should work.

Wiki Documentation

If Box is referred to as Yogstation, it should be changed to YogsBox.

Changelog

🆑
tweak: Yogstation has been renamed to YogsBox
/:cl:

@nmajask nmajask requested a review from a team as a code owner December 10, 2021 15:38
@Yogbot-13 Yogbot-13 added Mapping Will result in a change to a map. Tweak This PR contains changes to the game. labels Dec 10, 2021
@nmajask
Copy link
Contributor Author

nmajask commented Dec 10, 2021

Oh, I forgot to not commit the tail whitespace changes

Forgot about this
its YogsBox, not YogBox
Copy link
Contributor

@patpol4 patpol4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is most likely fine

@patpol4 patpol4 added the Awaiting - Action - HD Awaiting action from Jamie label Dec 10, 2021
@alexkar598
Copy link
Member

Cornflakes

@nmajask
Copy link
Contributor Author

nmajask commented Dec 11, 2021

Cornflakes

Sorted

Copy link
Contributor

@adamsong adamsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert your changes to tails.dm

@Hopekz
Copy link
Contributor

Hopekz commented Dec 15, 2021

Literally no point in doing this and people playing here for years know this map as yogstation

@UselessTheremin
Copy link
Contributor

Literally no point in doing this and people playing here for years know this map as yogstation

what about new players

@Hopekz
Copy link
Contributor

Hopekz commented Dec 17, 2021

what about new players

What do you think this PR does for new players?

All this PR is doing is changing the name of a map, something that will only effect people that know what this map is called.

@patpol4
Copy link
Contributor

patpol4 commented Dec 18, 2021

Makes the word boxstation less synonymous with the word yogstation, good change just for that.

@Hopekz
Copy link
Contributor

Hopekz commented Dec 18, 2021

Makes the word boxstation less synonymous with the word yogstation, good change just for that.

Oh this is one of those yogdev moments.
Didn't realize this was an anti-box PR until you said that and when you take away the anti-box energy this PR is just a seemingly pointless name change.

Not even sure what the vision is here anymore but if renaming a map gets you closer to it I guess it should be done?

Are any other maps being renamed to the yogs[name] syntax or is this just going to apply to box because of the recent drama? Like YogsKilo

@JamieD1
Copy link
Contributor

JamieD1 commented Dec 19, 2021

Missed a trick calling it YogBox. But also this feels extremely pointless. People know its box already. I dont know to be honest.

@Cartlord
Copy link
Contributor

Actually, when I got here it was days - might've been weeks - before I realized it was just your name for BoxStation. Good change.

@adamsong
Copy link
Contributor

In common usage the map is referred to as box, so why isn't the official name that?

And how is this an anti-box pr? It just clears up some ambiguity surrounding the term "yogstation"

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Awaiting - Action - HD Awaiting action from Jamie Mapping Will result in a change to a map. Tweak This PR contains changes to the game.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants