Skip to content
This repository was archived by the owner on May 22, 2025. It is now read-only.

Conversation

@nmajask
Copy link
Contributor

@nmajask nmajask commented Dec 22, 2021

Document the changes in your pull request

Remade this to fix some issues, original PR is #12869.

Renames Yogstation to YogsBox in, hopefully, the map vote and internally, as that is what everyone refers to it as and naming it after the server probably isn't the best idea. Will probably cause merge conflicts, but it shouldn't be hard to fix. Untested, should work.

Wiki Documentation

If Box is referred to as Yogstation, it should be changed to YogsBox.

Changelog

🆑
tweak: Yogstation has been renamed to YogsBox
/:cl:

nmajask added 24 commits May 11, 2021 19:44
added more detail to sigtech icon
new tourist and clerk icons
I uploaded the wrong file
Adds new signal technician and paramedic hud icons and reverts clerk's back, all requested by grimm-hollowknight
Adds brig physicians as a new job. There are a lot of changes, but in short:
- Added the job and many required things for it to work
- Edited maps to add lockers, landmarks, and update the brig medbay
- Added new clothing, PDAs, IDs, ect.
- Fixed some stuff I forget to change on some maps
- Added new landmark icons
Removed Brig Physician's ability to be antag and gave them a mindshield
- Removed the flash from the Brig Physician's starting equipment
- Removed security access for non-skeleton crew and weapon access from the Brig Physician
- Added skillcapes
- Updated the Infirmary in eclipse and omega
- Added a wall mounted flash on box
- Added an anesthetic tank and medical mask to the Brig Physician's locker
- Added icons for potential future support for the changes in yogstation13#11744
- Fixed a bunch of typos and minor mistakes (thanks TheGamerdk for pointing most of them out)
- Added support for yogstation13#11744 now that its merged
- Fixed a merge conflict
ahhhhhhhhhhhhhhh
I had to redo ALL of the map changes, so that was fun
Should fix some of the checks failing cause the Kilo file was messed up
- Re-did the changes to Kilo
- Fixed something I left in while testing stuff
- Fixes the Brig Physician's skill capes using the wrong job
Should fix most of wejengin2's issues with the map changes.
- Changes all the emergency wall meds to normal wall meds
- Might have fixed the APCs, but I don't know if I did it right
- MapMerged Kilo
- In Omega, I fixed the decals, added firelocks, and added vents/scrubbers in the brig infirmary
- In Box, I re-added some of the missing items
- In Delta, rearranged the lights and replaced them with tubes
- In Meta, I moved the morgue tray into the unused space, moved the blood freezer into the office, and added a shelf in the infirmary
Renames yogstation to yogsbox, this time with less merge conflicts and unintended changes.
@nmajask nmajask requested a review from a team as a code owner December 22, 2021 05:42
@Yogbot-13 Yogbot-13 added Mapping Will result in a change to a map. Tweak This PR contains changes to the game. labels Dec 22, 2021
@nmajask nmajask changed the title Renames yogstation Renames Yogstation to YogsBox Dec 22, 2021
@Hopekz
Copy link
Contributor

Hopekz commented Dec 22, 2021

You seem to unironically want this so here are real reasons not to merge this outside of "this is a box hate PR". Anti-boxers might as well dislike this post now without providing any real feedback as per usual:

  • This PR is fucking with the data collection we've been accumulating for years on the map named "yogstation". This presents an issue because all of a sudden a map named "yogstation" doesn't exist and this issue would have to be solved if this PR is to be merged. This problem doesn't exist if we just keep the same name.

  • A Rename to a map is not a good idea game-design wise. People tend to associate the name with a map over playing it for years.
    Think renaming dust2 from counter strike to "desert strike" or whatever. Dust2 never even had the number changed from 2 no matter how many iterations it got because of this reason.

  • How a map name "feels" is subjective at best.

  • This change is enforcing a standard that does not exist and is a slippery slope that will have to be applied to other maps for consistency.

What this means: we have had a full map created recently and we have named it Kilo Station. We did not name it YogsKilo. If this PR goes through it would make sense to update all other existing maps to the Yogs___ syntax which doesn't make sense for the above reasons as well.

  • yogstation has evolved way past the original "box" map over the years. This change is downplaying the transformation and effort that has gone in to the map. I myself have submitted full rework PR's for 'yogstation' over the years and took no inspiration from other "box" styled maps meaning that it is insulting in terms of the effort I put in to this project.

  • This is the most played map on our server. Not even by like a close majority I'm talking about being played 96%+ of the time. Why would you not want to associate what people have chosen to play and constantly maintain with the server name. This is why I personally thought this was originally a meme box hate PR because for some reason it is just completely ignoring that fact.

To back up this point please refer to the solid line under 'yogstation' from our official data given by our head mapper:
unknown-17-1

Subjective opinion:
Who actually cares about what the map is called. I personally mainly care that it is being changed after being implemented for years. I would be fine if this map was originally named "YogsPoop" as long as the map name stays consistent.

Subjective opinion 2:
"YogsBox" doesn't sound as cool as "YogStation"

@nmajask
Copy link
Contributor Author

nmajask commented Dec 22, 2021

  • This PR is fucking with the data collection we've been accumulating for years on the map named "yogstation". This presents an issue because all of a sudden a map named "yogstation" doesn't exist and this issue would have to be solved if this PR is to be merged. This problem doesn't exist if we just keep the same name.

Im not too sure about the way we keep that data, though I don't think like this would be too much of an issue as there are probably ways to fix this without too much work

  • A Rename to a map is not a good idea game-design wise. People tend to associate the name with a map over playing it for years.
    Think renaming dust2 from counter strike to "desert strike" or whatever. Dust2 never even had the number changed from 2 no matter how many iterations it got because of this reason.

I'm fairly sure they don't. Usually when I hear someone refer to it as "Box", like how you are referring to this as an Anti-Box PR and not an Anti-Yogstation PR, though I may just have not noticed people refer to it as yogstation.

  • This change is enforcing a standard that does not exist and is a slippery slope that will have to be applied to other maps for consistency.
    What this means: we have had a full map created recently and we have named it Kilo Station. We did not name it YogsKilo. If this PR goes through it would make sense to update all other existing maps to the Yogs___ syntax which doesn't make sense for the above reasons as well.

I don't see the issue with this, as it's not enforcing the standard much more as its already following it.

  • yogstation has evolved way past the original "box" map over the years. This change is downplaying the transformation and effort that has gone in to the map. I myself have submitted full rework PR's for 'yogstation' over the years and took no inspiration from other "box" styled maps meaning that it is insulting in terms of the effort I put in to this project.

Thats why its named YogsBox and not Box Station, as it's our verson of Box with stuff we have added and changed

  • This is the most played map on our server. Not even by like a close majority I'm talking about being played 96%+ of the time. Why would you not want to associate what people have chosen to play and constantly maintain with the server name. This is why I personally thought this was originally a meme box hate PR because for some reason it is just completely ignoring that fact.
    To back up this point please refer to the solid line under 'yogstation' from our official data given by our head mapper: unknown-17-1

Naming it the same as the server can make it easy to mix up the server and the map. For example, I tried seaching up yogstation on the discord to see if anyone actually refers to the map as yogstation and it brought up a ton of stuff not related to the map.

@nmajask
Copy link
Contributor Author

nmajask commented Dec 27, 2021

I think i am incapable of fixing merge conflicts without editing tails.dm

@patpol4
Copy link
Contributor

patpol4 commented Jan 17, 2022

@JamieD1 are we doing this or not

@nmajask
Copy link
Contributor Author

nmajask commented Jan 18, 2022

@JamieD1 are we doing this or not

If you do, tell me and ill fix the conflicts. I'm not going to fix them every time a new one pops up.

@patpol4
Copy link
Contributor

patpol4 commented Jan 18, 2022

If you do, tell me and ill fix the conflicts. I'm not going to fix them every time a new one pops up

That is why I'm trying to get Jamie to respond here

@patpol4
Copy link
Contributor

patpol4 commented Jan 26, 2022

@JamieD1 Please, yes/no

Reverts the removal of box
@nmajask nmajask requested a review from a team as a code owner January 30, 2022 23:05
Yogbot-13 added a commit that referenced this pull request Jan 30, 2022
@github-actions github-actions bot added the Config Config files need to be changed on the host for this to work label Jan 30, 2022
@JamieD1 JamieD1 merged commit 5c91612 into yogstation13:master Feb 2, 2022
Yogbot-13 added a commit that referenced this pull request Feb 2, 2022
KittyNoodle added a commit to KittyNoodle/Yogstation that referenced this pull request Feb 6, 2022
JamieD1 added a commit that referenced this pull request Feb 12, 2022
JamieD1 added a commit that referenced this pull request Feb 25, 2022
JamieD1 added a commit that referenced this pull request Feb 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Awaiting - Action - HD Awaiting action from Jamie Config Config files need to be changed on the host for this to work Mapping Will result in a change to a map. Tweak This PR contains changes to the game.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants