Stuns do not affect tail wagging, but paralyzes still do

[Sniblet]

I think someone accidentally did the exact opposite of what an inoffensive QoL PR proposed to do yesterday. I can’t contact them right now so I’m just offering to correct it for them

Most people don’t try to wag all round and so don’t know how annoying this is. Let me solve my own problem.
If you want to grief felinids, this only affects: sigils of submission, neural shock, vampire glare, seeing the singularity without mesons, CNS EMP, the Voice of God yelling STOP, and climbing tables. As you will not be using any of these to force waggers to type *wag again, this does not affect you.

Document the changes in your pull request

If a tailed creature is paralyzed (flash, electrocutions, slips, beepsky), they will not be able to start wagging and will stop wagging if they are.
If they are stunned (sigil of submission, CNS EMP, climbing tables), their tail is not paralyzed, so they can still start wagging and will continue to wag if they are.

Changelog

🆑
rscadd: added justice to the world
bugfix: Things that don’t paralyze you don’t paralyze your tail
/:cl:

[Hopekz]

Deceptive PR. Just write that it is a revert of #13343 instead of acting like this is something new

[Sniblet]

It’s not a revert, it’s a compromise. I would revert if I thought that would go through, but since it wouldn’t, I kept in the stun effect and am redoing #13341 with the distinction between stuns and paralyzes in mind.
If the description doesn’t make this clear, you can look at the files changed. I edited your work, I didn’t undo it. Not a revert.

[Marmio64]

Get a proper pr name

[Hopekz]

It’s not a revert, it’s a compromise.

It's kind of a never ending cycle with the instant "react to a PR" PR's.
Should we expect a compromise PR right after this one is merged to compromise on these changes too?

[Sniblet]

Well, I'm sorry, Hopekz, but the PR was my idea and Baiomu closed it without saying anything to me. I felt safe in reproposing it at least until someone was able to make a coherent point regarding why making it easier for a character to keep their tail wagging throughout the round was worse for the game than making it even more inconvenient.

Until a decent argument comes around, I can only assume that the only reason people have been opposing this is because it can make playing felinid more pleasant. It's funny when you're oppressing the degenerate cats ingame, it's just toxic when you do it on the git.

Since I don't expect anyone to care about that after the first PR was silently closed with 11 thumbs-down, I gave a little by leaving in the ability for paralyzes to forcibly stop wagging.

If anyone decides to try and go back on what this PR does, I will be shocked at the display of bad faith. To be clear, stuns as opposed to paralyzes are where your character's movement and ability to use their hands are suspended, but they don't fall down. You can count on your fingers the number of things in the entire game that do that: sigils of submission, neural shock, vampire glare, seeing the singularity without mesons, CNS EMP, the Voice of God yelling STOP, and climbing tables are all I can call to mind. This PR, in its finished form, would only take away those things' abilities to grief waggers.
You still have the unlimited ability flash them so they have to stop for five seconds (up from one before your fix), at the cost of half of what I wanted, which was to not have wagging interrupted when I slip. Rejoice.

[Hopekz]

Well, I'm sorry, Hopekz

I forgive you

[Sniblet]

Okay I think this does the intended thing from the title, will test because this isn't copypasta so I don't know
I might have a way to also do this for slips, but I don't know if it will add an unintended amount of jank and I should probably do it separately because this is already controversial (please see previous rant for why it shouldn't be)

[Sniblet]

It does not do the intended
If anybody knows how to make paralyzes stop wagging without stuns also doing it, speak up anytime

[Sniblet]

"could add an arg that differentiates if its a stun or whatever and check that, or you could make a separate proc for each of them and copy the code for spec_stun"
someone translate

[Sniblet]

Tested, works as described

[ToasterBiome]

Well, I'm sorry, Hopekz, but the PR was my idea and Baiomu closed it without saying anything to me.

For the record, it was my PR and I closed it because I merged another PR that invalidates it. Feel free to PM me with any queries you might have instead of name dropping me

[nmajask]

Suggested change

	amount = dna.species.spec_stun(src, amount)
	if(!dna || !dna.species)
	return ..()
	amount = dna.species.spec_stun(src, amount)

Add a check to make sure dna and dna.species aren't null

[JamieD1]

A stun is just as bad as a paralyze, I don't get this point of this PR. Tail wagging should be stopped with any sort of immobilize.

[Sniblet]

A stun is just as bad as a paralyze, I don't get this point of this PR. Tail wagging should be stopped with any sort of immobilize.

I wrote paragraphs about why this was wrong
Why is it so hard to make my life a little easier without harming anyone else