Skip to content
This repository was archived by the owner on May 22, 2025. It is now read-only.

Conversation

@ToasterBiome
Copy link
Contributor

@ToasterBiome ToasterBiome commented Mar 16, 2022

Document the changes in your pull request

Inspired by BeeStation/BeeStation-Hornet#5169 and BeeStation/BeeStation-Hornet#5417 and @nmajask.

Pilots "typing indicators" for players, showing when they're typing. Yes this is "typebait: now a feature", don't know how it's going to fly on yogs but it's worked on bee for over six months, plus yogs mins dont really play around and will rapidly people's elbow you if you're being a shitter and abusing it

nmajask showed me the PR and instead of porting it along with it's fix, i thought it would be better to try to code it from scratch from what yogs has to offer and how yogs deals with these overlays, along with trying to avoid the latency fix in the first place by not handling it in the same way. If this doesn't work, expect nmajask's port soon after.

QPRvpWElxC.mp4

also they animate now when they pop up, thanks nmajask (wtf he didnt tell me)

Changelog

🆑 Nmajask, ToasterBiome
rscadd: adds a typing indicator
rscadd: adds animated typing sprites by nmajask
/:cl:

@ToasterBiome ToasterBiome requested a review from a team as a code owner March 16, 2022 06:26
@Yogbot-13 Yogbot-13 added Feature This adds new content to the game Sprites This PR has spriting changes labels Mar 16, 2022
@Firewolf34
Copy link
Contributor

Firewolf34 commented Mar 16, 2022

Please make this configurable in the settings like it is on other servers. I don't want people knowing when I'm typing all the time. Other than that, very cool stuff.

@ToasterBiome ToasterBiome changed the title Adds Typing Indicator Adds Typing Indicator and also animated bubbles??? Mar 16, 2022
@yacabo
Copy link
Contributor

yacabo commented Mar 16, 2022

Does this work for the TAB bar talk or just the talk popup?

@ToasterBiome
Copy link
Contributor Author

Does this work for the TAB bar talk or just the talk popup?

i dont think the client sends any information typed into the bottom bar until enter is pressed, either way - no

@Chubbygummibear
Copy link
Contributor

Finally i get to know if the person staring at me is responding or is actually just pumped full of fluoride

@LazennG
Copy link
Contributor

LazennG commented Mar 16, 2022

i know this will make it easier for typebaiters but love that i can know when a conversation ends so i dont feel bad about shooting someone

Copy link
Contributor

@Bibby0110 Bibby0110 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ehhhh, just port the beestation thing, those guys are cool

seemingly it also only applies to people who were near you when you started talking?

@ToasterBiome
Copy link
Contributor Author

ehhhh, just port the beestation thing, those guys are cool

seemingly it also only applies to people who were near you when you started talking?

beestations code is tacked on, if their message bubble is generated the same as ours then it generates the typing bubble in a totally different way.

Also I don’t agree with making a custom clientside window to fix the latency issue

and yes it only applies to people near you when you start talking because it’s generated in the same way that the normal bubbles are generated

Yogbot-13 added a commit that referenced this pull request Mar 17, 2022
Yogbot-13 added a commit that referenced this pull request Mar 17, 2022
Co-authored-by: TheGamerdk <5618080+TheGamerdk@users.noreply.github.com>
@ToasterBiome ToasterBiome requested a review from Bibby0110 March 18, 2022 08:10
Yogbot-13 added a commit that referenced this pull request Mar 22, 2022
Yogbot-13 added a commit that referenced this pull request Mar 23, 2022
Yogbot-13 added a commit that referenced this pull request Mar 23, 2022
@ToasterBiome ToasterBiome requested a review from nmajask March 25, 2022 10:42
Yogbot-13 added a commit that referenced this pull request Apr 16, 2022
Yogbot-13 added a commit that referenced this pull request Apr 16, 2022
Yogbot-13 added a commit that referenced this pull request Apr 17, 2022
Yogbot-13 added a commit that referenced this pull request Apr 17, 2022
@ToasterBiome ToasterBiome dismissed stale reviews from nmajask and Bibby0110 April 18, 2022 19:37

no longer

Yogbot-13 added a commit that referenced this pull request Apr 18, 2022
Yogbot-13 added a commit that referenced this pull request Apr 20, 2022
Yogbot-13 added a commit that referenced this pull request Apr 20, 2022
Yogbot-13 added a commit that referenced this pull request Apr 21, 2022
Yogbot-13 added a commit that referenced this pull request Apr 21, 2022
Yogbot-13 added a commit that referenced this pull request Apr 21, 2022
Yogbot-13 added a commit that referenced this pull request Apr 21, 2022
Yogbot-13 added a commit that referenced this pull request Apr 21, 2022
Yogbot-13 added a commit that referenced this pull request Apr 22, 2022
Yogbot-13 added a commit that referenced this pull request Apr 22, 2022
Yogbot-13 added a commit that referenced this pull request Apr 22, 2022
Yogbot-13 added a commit that referenced this pull request Apr 22, 2022
Yogbot-13 added a commit that referenced this pull request Apr 22, 2022
Yogbot-13 added a commit that referenced this pull request Apr 23, 2022
Yogbot-13 added a commit that referenced this pull request Apr 26, 2022
@JamieD1 JamieD1 merged commit 2e92bb4 into yogstation13:master Apr 30, 2022
Yogbot-13 added a commit that referenced this pull request Apr 30, 2022
@ToasterBiome ToasterBiome deleted the typing-indicator branch April 16, 2024 21:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Feature This adds new content to the game Not Modular This PR does not put its unique content in the yogstation sub directory Sprites This PR has spriting changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.