Skip to content
This repository was archived by the owner on May 22, 2025. It is now read-only.

Conversation

@TheRyeGuyWhoWillNowDie
Copy link
Contributor

@TheRyeGuyWhoWillNowDie TheRyeGuyWhoWillNowDie commented May 10, 2022

Document the changes in your pull request

Bloodbrothers are one of the weakest antagonists. They're also the only syndicate antagonist to have NO syndicate equipment. By giving them access to the items from 'makeshift weapons' they can have more room to improvise, which is what they're meant to do anyways.

Wiki Documentation

Probably put a blurb about them having the makeshift weapons recipes on the bloodbrother page.

Changelog

🆑
rscadd: Blood brothers will now start with all of the makeshift weapons recipes learned.
/:cl:

Closes:#13954

@Yogbot-13 Yogbot-13 added the Feature This adds new content to the game label May 10, 2022
Comment on lines 31 to 36
var/list/crafting_recipe_types = list(/datum/crafting_recipe/baseball_bat, /datum/crafting_recipe/lance, /datum/crafting_recipe/knifeboxing, /datum/crafting_recipe/flamethrower, /datum/crafting_recipe/pipebomb, /datum/crafting_recipe/makeshiftpistol, /datum/crafting_recipe/makeshiftmagazine, /datum/crafting_recipe/makeshiftsuppressor, /datum/crafting_recipe/makeshiftcrowbar, /datum/crafting_recipe/makeshiftwrench, /datum/crafting_recipe/makeshiftwirecutters, /datum/crafting_recipe/makeshiftweldingtool, /datum/crafting_recipe/makeshiftmultitool, /datum/crafting_recipe/makeshiftscrewdriver, /datum/crafting_recipe/makeshiftknife, /datum/crafting_recipe/makeshiftpickaxe, /datum/crafting_recipe/makeshiftradio)

for(var/crafting_recipe_type in crafting_recipe_types)
var/datum/crafting_recipe/R = crafting_recipe_type
owner.teach_crafting_recipe(crafting_recipe_type)
to_chat(owner,span_notice("You learned how to make [initial(R.name)]."))
Copy link
Contributor

@tattax tattax May 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
var/list/crafting_recipe_types = list(/datum/crafting_recipe/baseball_bat, /datum/crafting_recipe/lance, /datum/crafting_recipe/knifeboxing, /datum/crafting_recipe/flamethrower, /datum/crafting_recipe/pipebomb, /datum/crafting_recipe/makeshiftpistol, /datum/crafting_recipe/makeshiftmagazine, /datum/crafting_recipe/makeshiftsuppressor, /datum/crafting_recipe/makeshiftcrowbar, /datum/crafting_recipe/makeshiftwrench, /datum/crafting_recipe/makeshiftwirecutters, /datum/crafting_recipe/makeshiftweldingtool, /datum/crafting_recipe/makeshiftmultitool, /datum/crafting_recipe/makeshiftscrewdriver, /datum/crafting_recipe/makeshiftknife, /datum/crafting_recipe/makeshiftpickaxe, /datum/crafting_recipe/makeshiftradio)
for(var/crafting_recipe_type in crafting_recipe_types)
var/datum/crafting_recipe/R = crafting_recipe_type
owner.teach_crafting_recipe(crafting_recipe_type)
to_chat(owner,span_notice("You learned how to make [initial(R.name)]."))
var/obj/item/book/granter/crafting_recipe/weapons/W
for(var/datum/crafting_recipe/R in W.crafting_recipe_types)
owner.teach_crafting_recipe(R)
to_chat(owner,span_notice("You learned how to make [initial(R.name)]."))

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you very cool

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do this so we don't have to update it as well as the crafting book every time something new gets added

@JamieD1
Copy link
Contributor

JamieD1 commented May 16, 2022

What we doing with this,

@eminolm
Copy link

eminolm commented May 18, 2022

are we going to have both minor bb rework and this or only this or only minor bb rework. if we are gonna only have one of then there should be a quickfire vote about this.

@TheRyeGuyWhoWillNowDie
Copy link
Contributor Author

closing this because i personally believe the other blood brother rework is a better choice

@JamieD1
Copy link
Contributor

JamieD1 commented May 21, 2022

I prefer this one to be honest.

@JamieD1 JamieD1 merged commit 8b77243 into yogstation13:master May 22, 2022
Yogbot-13 added a commit that referenced this pull request May 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Feature This adds new content to the game

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants