Skip to content
This repository was archived by the owner on May 22, 2025. It is now read-only.

Conversation

@adamsong
Copy link
Contributor

@adamsong adamsong commented Oct 11, 2022

Steals the mail code from #12948 because cool pr that went dormant

Document the changes in your pull request

Ports tgstation/tgstation#58146

  • Mail boxes show up in cargo shuttle
  • Mail has credits for the people addressed on the letter
  • Mail can have job-dependent gifts too
  • Cargo can deliver mail if they want or tell people to fetch it
  • Some holidays are mail holidays, meaning no mail on them
  • Can't open someone elses mail

Weights and chances for loots

Spriting

Sprites for mail and stuff

Wiki Documentation

Mail arrives on shuttle, needs removed before the shuttle can leave

Changelog

🆑 adamsong, Inari-Whitebear, ArcaneMusic, Jaw-sh, Tralezab
rscadd: Mail for cargo
wip: This is work in progress
imageadd: mail images and mail crate image
/:cl:

@adamsong adamsong requested a review from a team as a code owner October 11, 2022 23:03
@Yogbot-13 Yogbot-13 added the Feature This adds new content to the game label Oct 11, 2022
@Mqiib
Copy link
Contributor

Mqiib commented Oct 11, 2022

YES MAIL I LOVE IT

/obj/item/stack/sheet/mineral/gold = 5,
/obj/item/stack/sheet/mineral/uranium = 4,
/obj/item/stack/sheet/mineral/diamond = 3,
/obj/item/gun/ballistic/rifle/boltaction = 1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fitting a 6-foot long bolt action rifle into an envelope 🤔

@adamsong adamsong changed the title Doing mail again [Port] Doing mail again Oct 12, 2022
@adamsong
Copy link
Contributor Author

Added a verb to print a list of all goodies, their weights and relative percents, as well as highlight any jobs with no job specific loot. I'll use this at some point to finalize loot tables

Copy link
Contributor

@cuackles cuackles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

try to @ the original sprite artist if posible

@adamsong
Copy link
Contributor Author

All the authors from the original pr are credited, unsure of who did sprites specifically

@github-actions github-actions bot added the Admin This PR affects administrators label Oct 12, 2022
@CMOisLing
Copy link
Contributor

There should be some way of stealing mail if your a traitor cargo tech.

@adamsong adamsong added the Test Merge - Requested This PR is waiting for a test merge to be scheduled label Oct 12, 2022
@adamsong
Copy link
Contributor Author

Thats illegal

@JamieD1 JamieD1 merged commit fa832b9 into master Oct 29, 2022
@JamieD1 JamieD1 deleted the doing-mail branch October 29, 2022 13:41
Yogbot-13 added a commit that referenced this pull request Oct 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Admin This PR affects administrators Feature This adds new content to the game Test Merge - Requested This PR is waiting for a test merge to be scheduled

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants