[Port] [WIP] Cargo mail for crew

[Inari-Whitebear]

WIP

• Tested a bit, but not fully yet.

Todo

• Also still need to figure out all the gifts on YogStation or find replacements for things that do not exist.
• Maybe also have to see about adjusting the credit amount
• Maybe change junkmail messages
• Find/make better pamphlets
• check for other icons to port (e.g. mail bag)
• Test more
• Make mail emag-able? (brought up in Discord)

Document the changes in your pull request

Ports tgstation/tgstation#58146

• Mail boxes show up in cargo shuttle
• Mail has credits for the people addressed on the letter
• Mail can have job-dependent gifts too
• Cargo can deliver mail if they want or tell people to fetch it
• Some holidays are mail holidays, meaning no mail on them
• Can't open someone elses mail

Wiki Documentation

Mail boxes show up on cargo shuttle
Cargo shuttle can't depart if mail is still on-board

Changelog

🆑 Inari-Whitebear, ArcaneMusic, Jaw-sh, Tralezab
rscadd: Mail for cargo
wip: This is work in progress
imageadd: mail images and mail crate image
/:cl:

[bruhlookatthisdood]

I love this, always liked that system from TG and was sad when I moved to yog that it wasn't here.

[Marmio64]

some of the mail goodies look kind of insane, you can literally get a bolt action rifle as a cargo tech. Perhaps turn it down a little? For that specific example maybe an improvised shotgun instead.

[Inari-Whitebear]

@Marmio64
Yeah, for now I just copied the gifts. Balance is something to talk about though.

For that point, whether or not it changes your view, you should remember though, mail is a bit limited. The max amount of mail that should show up on the cargo shuttle is 3 per minute.

In addition the whole list for cargo tech is:
/obj/item/stack/spacecash/c100 = 25,
/obj/item/stack/spacecash/c200 = 15,
/obj/item/stack/spacecash/c50 = 10,
/obj/item/pizzabox = 10,
/obj/item/stack/spacecash/c500 = 5,
/obj/item/stack/sheet/mineral/gold = 5,
/obj/item/stack/sheet/mineral/uranium = 4,
/obj/item/stack/sheet/mineral/diamond = 3,
/obj/item/stack/spacecash/c1000 = 1,
/obj/item/gun/ballistic/rifle/boltaction = 1

For a normal mail one of those is picked, giving bolt action a 1.266% chance to be in the mail
Now there is a 30% chance that the specific mail spawns as an envelope, which has 2 items inside, so then it would be a little higher chance that at least one of them is the bolt action.
Not sure if that affects your view on the balancing of it, but just wanted to note it.

[Inari-Whitebear]

Also not quite sure if to add a bunch of things from the gifts (such as bee cubes or caramel donuts) or find replacements

[bruhlookatthisdood]

Also not quite sure if to add a bunch of things from the gifts (such as bee cubes or caramel donuts) or find replacements

Give me my fucking donuts

[adamsong]

Looks pretty good, a few minor comments. I would like to see this test merged to see how the playerbase handles it.

[Inari-Whitebear]

Well since I can't seem to reply directly...
@adamsong

"Not sure about wizards and nuke ops, but silicons don't have the Station faction, and therefore can be sent mail"

• Not sure what you mean here. "Don't have the Station faction and therefore can be sent mail", do you mean "can't be send mail"?
  Also not sure about that either, I just saw code\modules\jobs\job_types\ai.dm listing faction = "Station"

[adamsong]

Mail cannot be delivered to people with the Station faction, which according to the comment is supposed to be nukies, wizards, and silicons, however when I did VV on the AI, it did not have that faction.
This is the factions on a borg:

[Inari-Whitebear]

Oh, guess I screwed up the check anyway, should be "only deliver to Station faction"

[adamsong]

Players are not the station faction though, you'll need to check the faction of the job

[adamsong]

Also, I think you should re-enable SR for dead ian

[Inari-Whitebear]

Yeah, thats currently disabled because it was like the other job gifts, still have to find the right paths and the like

[Inari-Whitebear]

Amount of mail should be better now
I apparently did a dumb on the calculation for how much mail should be waiting....

As far as I understand this fires every 5 minutes... before it would take that in the wait time (5 MINUTES, which is 5 * 60 * 10 or 3000) and do 3000 * 0.2.. so it would add 600 waiting mails every 5 minutes

Fixed it to be accurate.. so now it should be 15 mails per 5 minutes

[ToasterBiome]

Suggestions for mail (since getting credits is lame)

Engineering: Higher tier charged cells (not bluespace)
Science: Slime Mutation Potions/Slime Stability Potions, maybe some T3/T4 parts occasionally
Chemist/CMO: Small amounts of Lemoline
Cargo Tech: small amount of plastic

[Inari-Whitebear]

Yeah, getting credits is a bit more useful when they are your only source of credits - like on some stations I've seen.

Goodies are definitely more exciting.

[ToasterBiome]

@Inari-Whitebear any work on this?

[Inari-Whitebear]

Well, I've asked questions. I've not gotten answers yet. So no work currently.
I like your suggestions too, but without any other input, no idea if they'd even be accepted balance-wise or the like.

[Bibby0110]

Feel free to open a new PR when you figure out the problems :)