Skip to content
This repository was archived by the owner on May 22, 2025. It is now read-only.

Conversation

@SapphicOverload
Copy link
Contributor

@SapphicOverload SapphicOverload commented Dec 2, 2022

Document the changes in your pull request

Hypernoblium is now more endothermic and has a limit to how much can form in a tick which can be increased by adding BZ and more heat.

Highly recommend merging #17092 first.

Closes #16874

Changelog

🆑
tweak: hypernoblium formation is more endothermic and doesn't form all at once
/:cl:

@Yogbot-13 Yogbot-13 added the Tweak This PR contains changes to the game. label Dec 2, 2022
@warface1234455
Copy link
Contributor

Kek

@knightshade0
Copy link

I still don't think we actually need to change hypernob formation given how it largely exists as a novelty, but if we do insist on changing it this is a solid implementation.

Heat/production curve looks solid. The other PR was bizarre (among other reasons) because physics doesn't really work in terms of arbitrary maximum values- everything works on curves. The math regarding what we'd actually do in game seems workable as well.

It makes sense conceptually and it works for gameplay so I have no opposition to it.

@Simplehorror
Copy link
Contributor

hey how about we don't put closes for someone else's PR?

@SapphicOverload
Copy link
Contributor Author

My PR makes yours obsolete and will cause conflicts if both get merged

@chemistrymain2
Copy link

hey how about we don't put closes for someone else's PR?

their pr is better

Copy link
Contributor

@MajManatee MajManatee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

those gasses sure are funny

@JamieD1 JamieD1 merged commit 0285cd6 into yogstation13:master Dec 17, 2022
Yogbot-13 added a commit that referenced this pull request Dec 17, 2022
@SapphicOverload SapphicOverload deleted the noblium-reaction-rework branch May 13, 2023 14:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Tweak This PR contains changes to the game.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants