This repository was archived by the owner on May 22, 2025. It is now read-only.
Backports several SSlighting improvements: overlay lighting #17271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Have you tested how this looks on the replay viewer? |
Contributor
Author
|
Nope, I don't use replays |
Member
|
Try it, go to https://replays.yogstation.net/ and hit choose file and navigate to the logs of your local testing and see what it gives you. |
Contributor
Author
|
The overlay isn't shown in the replay, any way to make it work? |
Contributor
|
I'm gonna be completely honest, I don't see a difference. Comparison screenies? |
ThatLing
added
the
Test Merge - Requested
JamieD1
pushed a commit
that referenced
this pull request
Jan 11, 2023
JamieD1
pushed a commit
that referenced
this pull request
Jan 12, 2023
JamieD1
pushed a commit
that referenced
this pull request
Jan 12, 2023
JamieD1
pushed a commit
that referenced
this pull request
Jan 12, 2023
Contributor
|
very nice in practice |
Closed
ThatLing
added
Mapping
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Document the changes in your pull request
This ports a few lighting improvements, the most exciting one is overlay lighting.
This should be test-merged for some time, likely some stuff related to slings will break
List of ported PRs, credits to the original authors:
Changelog
🆑 Rohesie
rscadd: Dynamic lights move smoother now
/:cl: