This repository was archived by the owner on May 22, 2025. It is now read-only.
Gunlights are back (probably) #17773
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
ill be able to test this when im not at my real job. |
ThatLing
suggested changes
Feb 3, 2023
Co-authored-by: Ling <lingbleed@gmail.com>
Contributor
Author
|
I think the code ALSO handled the light movement itself, and I just forgot to remove that bit since its handled elsewhere |
ThatLing
suggested changes
Feb 3, 2023
Contributor
ThatLing
left a comment
ThatLing
left a comment
There was a problem hiding this comment.
You removed the set_light_on and didn't add the vars
Contributor
Author
|
I reckon thats all thats needed |
Contributor
Author
|
The light is handled elsewhere, all this is doing is handling the item overlay, so i removed the set_light_on stuff completley |
ThatLing
approved these changes
Feb 3, 2023
Contributor
|
don't think knife is shown on the PKA either, but that can be a different PR |
Yogbot-13
added a commit
that referenced
this pull request
Feb 5, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Document the changes in your pull request
Not gonna lie, I have no idea if this works right now, I am just guessing, but it seems like this was the issue.
a certain SOMEONE, not naming names (ling) might have removed our gunlight overlay sytem when updating our lighting to be not shit in #17271
Also closes #17474
thanks ynot for pointing out where the issue came from
Anyways, hopefully this fixes that.
Changelog
🆑
bugfix: Gunlights fixed
/:cl: