Skip to content
This repository was archived by the owner on May 22, 2025. It is now read-only.

Conversation

@JohnFulpWillard
Copy link
Contributor

@JohnFulpWillard JohnFulpWillard commented Jul 23, 2023

Document the changes in your pull request

Removes do_atom, do_after_mob and do_mob, merging it all into do_after.
Also adds interaction keys, so people can (generally) no longer stack multiple progress bars on stuff

This helps massively in maintainability, as these 4 things are all copy pastes of eachother, and there's not much reason to keep them all around when they all essentially do the same thing.
It also makes adding new instances of it way easier.

What is a do_after

Nearly anything in-game that uses progress bars (like surgery) used to be stackable.
With interaction keys, you can only do one interaction on a thing at a time. Example; this removes being able to do surgery on multiple limbs at once.

Wiki Documentation

You can no longer stack do afters, if that's a thing in surgery or something.

Changelog

🆑 JohnFulpWillard & Mothblocks
bugfix: Removes being able to stack do_afters on things (like surgery on several limbs on the same person).
rscdel: Removed do_mob, do_after_mob and do_atom.
tweak: You now do CPR faster after the first attempt.
/:cl:

@Yogbot-13 Yogbot-13 added Fix This fixes an issue. Please link issues in fix PRs Revert / Deletion Altoids is probably mad about this labels Jul 23, 2023
@JohnFulpWillard JohnFulpWillard changed the title Removse do_atom, do_after_mob and do_mob (also interaction key stuff) Removes do_atom, do_after_mob and do_mob (also interaction key stuff) Jul 23, 2023
@JohnFulpWillard JohnFulpWillard marked this pull request as ready for review July 29, 2023 08:39
Yogbot-13 added a commit that referenced this pull request Jul 29, 2023
@TaelynTheLost
Copy link

Stacking actions is extremely important to medical. CPR for example, is near useless since it's like 4 times slower than before. It ruins the tempo, and it used to have the perfect tempo of real CPR. I don't see why you would even need to remove it. Chaining actions allowed you to keep a continuous flow, even when the server has a lag spike. A flow, that for med, can mean life or death.

@athena413
Copy link
Contributor

can you add an exception for advanced roasting stick. stacking 1287037819 actions to make a supermatter-grilled supermatter-grilled supermatter-grilled supermatter-grilled supermatter-grilled supermatter-grilled supermatter-grilled supermatter-grilled supermatter-grilled supermatter-grilled supermatter-grilled supermatter-grilled supermatter-grilled supermatter-grilled supermatter-grilled supermatter-grilled sausage is funny and i want it

@JohnFulpWillard
Copy link
Contributor Author

😦

Yogbot-13 added a commit that referenced this pull request Jul 30, 2023
@iloveloopers
Copy link
Contributor

LET ME WALK AND EAT AT THE SAME TIME

Yogbot-13 added a commit that referenced this pull request Jul 30, 2023
@Yarinoi
Copy link
Contributor

Yarinoi commented Jul 30, 2023

awful pr

i cant wait for it to take 5x10^28 years for me to cpr away the oxygen damage of someone i just defibbed
i cant wait for secoffs to have to spend an eternity having to strip one guy

this may help coders in some way but its awful for the people who actually play the game. surely theres a way of doing whatever you wanted to do without this shit.

@JohnFulpWillard
Copy link
Contributor Author

Idk if you're still just playing on the first commit or what but both those things were addressed

Yogbot-13 added a commit that referenced this pull request Jul 30, 2023
@ynot01 ynot01 added the TESTMERGED This PR is currently live in a test merge. label Jul 30, 2023
Yogbot-13 added a commit that referenced this pull request Jul 30, 2023
@Yarinoi
Copy link
Contributor

Yarinoi commented Jul 31, 2023

Idk if you're still just playing on the first commit or what but both those things were addressed

oh

nice

@iloveloopers
Copy link
Contributor

You can't draw bows while moving. Pretty sure you could draw bows while moving before

Yogbot-13 added a commit that referenced this pull request Jul 31, 2023
@JohnFulpWillard
Copy link
Contributor Author

Bows fixed, i read the code wrong and accidentally swapped it backwards.

Yogbot-13 added a commit that referenced this pull request Aug 1, 2023
Yogbot-13 added a commit that referenced this pull request Aug 1, 2023
Yogbot-13 added a commit that referenced this pull request Aug 3, 2023
Yogbot-13 added a commit that referenced this pull request Aug 3, 2023
@Mqiib
Copy link
Contributor

Mqiib commented Aug 5, 2023

Horror soul suck gets cancelled when the host moves which makes it half impossible to do your objective. It's not supposed to be cancelled.

Yogbot-13 added a commit that referenced this pull request Aug 8, 2023
Yogbot-13 added a commit that referenced this pull request Aug 9, 2023
@ToasterBiome ToasterBiome merged commit 9640d15 into yogstation13:master Aug 20, 2023
@Yogbot-13 Yogbot-13 added the Tweak This PR contains changes to the game. label Aug 20, 2023
Yogbot-13 added a commit that referenced this pull request Aug 20, 2023
@JohnFulpWillard JohnFulpWillard deleted the do-after branch October 23, 2023 10:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Fix This fixes an issue. Please link issues in fix PRs Revert / Deletion Altoids is probably mad about this TESTMERGED This PR is currently live in a test merge. Tweak This PR contains changes to the game.

Projects

Status: Completed Ports

Development

Successfully merging this pull request may close these issues.

9 participants