Skip to content
This repository was archived by the owner on May 22, 2025. It is now read-only.

Conversation

@adamsong
Copy link
Contributor

Document the changes in your pull request

Slurring was refactored by code stolen from tgstation/tgstation#66031 in #18514 but the actual slurring files were not stolen.

Changelog

🆑
bugfix: fixed slurring
/:cl:

@Yogbot-13 Yogbot-13 added the Fix This fixes an issue. Please link issues in fix PRs label Aug 29, 2023
Copy link
Contributor

@ToasterBiome ToasterBiome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical bugfix

@Hopekz
Copy link
Contributor

Hopekz commented Aug 29, 2023

critical bugfix

It's been broken for 5 months

@ToasterBiome
Copy link
Contributor

critical bugfix

It's been broken for 5 months

ok and

@ToasterBiome ToasterBiome merged commit 3d3167b into master Aug 29, 2023
@ToasterBiome ToasterBiome deleted the fix-slurring branch August 29, 2023 07:23
Yogbot-13 added a commit that referenced this pull request Aug 29, 2023
@Hopekz
Copy link
Contributor

Hopekz commented Aug 29, 2023

critical bugfix

It's been broken for 5 months

ok and

Tl;Dr: only pointing out it wasn't critical.

Only matters because it would make us look bad if a "critical" fix took 5 months to get here.

Critical is a level usually reserved for something that impacts a major functionality to the point where the game can't be delivered without fixing the bug.

Basically by how we usually go about things and labeling this critical you are saying that the game has been unplayable for the last 5 months when this was broken.

@ToasterBiome
Copy link
Contributor

critical bugfix

It's been broken for 5 months

ok and

Tl;Dr: only pointing out it wasn't critical.

Only matters because it would make us look bad if a "critical" fix took 5 months to get here.

Critical is a level usually reserved for something that impacts a major functionality to the point where the game can't be delivered without fixing the bug.

Basically by how we usually go about things and labeling this critical you are saying that the game has been unplayable for the last 5 months when this was broken.

image

@Hopekz
Copy link
Contributor

Hopekz commented Aug 29, 2023

critical bugfix

It's been broken for 5 months

ok and

Tl;Dr: only pointing out it wasn't critical.
Only matters because it would make us look bad if a "critical" fix took 5 months to get here.
Critical is a level usually reserved for something that impacts a major functionality to the point where the game can't be delivered without fixing the bug.
Basically by how we usually go about things and labeling this critical you are saying that the game has been unplayable for the last 5 months when this was broken.

image

IMG_20230829_032332

Runian pushed a commit to Runian/Yogstation that referenced this pull request Aug 30, 2023
Runian pushed a commit to Runian/Yogstation that referenced this pull request Aug 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Fix This fixes an issue. Please link issues in fix PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants